From: <Tudor.Ambarus@microchip.com>
To: <bianpan2016@163.com>, <broonie@kernel.org>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <cyrille.pitchen@atmel.com>
Cc: <linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] spi: atmel: Put allocated master before return
Date: Thu, 21 Jan 2021 12:00:25 +0000 [thread overview]
Message-ID: <812b9c86-22fc-f59d-7f31-cfea4c07f708@microchip.com> (raw)
In-Reply-To: <20210120050025.25426-1-bianpan2016@163.com>
On 1/20/21 7:00 AM, Pan Bian wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The allocated master is not released. Goto error handling label rather
> than directly return.
>
> Fixes: 04242ca4e891 ("spi: atmel: Use SPI core DMA mapping framework")
The correct fixes tag is:
Fixes: 5e9af37e46bc ("spi: atmel: introduce probe deferring")
With this addressed, one can add:
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
> drivers/spi/spi-atmel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 948396b382d7..f429436082af 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1590,7 +1590,7 @@ static int atmel_spi_probe(struct platform_device *pdev)
> if (ret == 0) {
> as->use_dma = true;
> } else if (ret == -EPROBE_DEFER) {
> - return ret;
> + goto out_unmap_regs;
> }
> } else if (as->caps.has_pdc_support) {
> as->use_pdc = true;
> --
> 2.17.1
>
>
next parent reply other threads:[~2021-01-21 12:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210120050025.25426-1-bianpan2016@163.com>
2021-01-21 12:00 ` Tudor.Ambarus [this message]
2021-01-21 19:41 ` [PATCH 1/1] spi: atmel: Put allocated master before return Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=812b9c86-22fc-f59d-7f31-cfea4c07f708@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bianpan2016@163.com \
--cc=broonie@kernel.org \
--cc=cyrille.pitchen@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).