From: Teresa Remmet <t.remmet@phytec.de>
To: Andreas Klinger <ak@it-klinger.de>, linux-omap@vger.kernel.org
Cc: bcousson@baylibre.com, tony@atomide.com, robh+dt@kernel.org,
mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: am335x-wega.dtsi: fix wrong card detect pin level
Date: Mon, 22 Jul 2019 10:06:05 +0200 [thread overview]
Message-ID: <812cb14400ee43176c2118247c8c47230b9206c2.camel@phytec.de> (raw)
In-Reply-To: <20190709183209.y64keopah5rkismc@arbad>
Hello Andreas,
Am Dienstag, den 09.07.2019, 20:32 +0200 schrieb Andreas Klinger:
> mmc cards on mmc1 are not detected because of wrong card detect (cd)
> level.
>
> Change cd from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW.
>
> This is necessary because of commit e63201f19438 ("mmc: omap_hsmmc:
> Delete platform data GPIO CD and WP")
Thanks for noticing. But the fix is already in master.
Teresa
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
> arch/arm/boot/dts/am335x-wega.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/am335x-wega.dtsi
> b/arch/arm/boot/dts/am335x-wega.dtsi
> index b7d28a20341f..84581fed3d06 100644
> --- a/arch/arm/boot/dts/am335x-wega.dtsi
> +++ b/arch/arm/boot/dts/am335x-wega.dtsi
> @@ -157,7 +157,7 @@
> bus-width = <4>;
> pinctrl-names = "default";
> pinctrl-0 = <&mmc1_pins>;
> - cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
> + cd-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
>
> --
> 2.11.0
>
>
next prev parent reply other threads:[~2019-07-22 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 18:32 [PATCH] ARM: dts: am335x-wega.dtsi: fix wrong card detect pin level Andreas Klinger
2019-07-22 8:06 ` Teresa Remmet [this message]
2019-08-13 10:17 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=812cb14400ee43176c2118247c8c47230b9206c2.camel@phytec.de \
--to=t.remmet@phytec.de \
--cc=ak@it-klinger.de \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).