linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luca Weiss <luca@z3ntu.xyz>
To: linux-arm-msm@vger.kernel.org, neil.armstrong@linaro.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, afd@ti.com,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Das Srinagesh <gurus@codeaurora.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] bindings: pm8941-misc: rename misc node name
Date: Wed, 02 Nov 2022 16:43:14 +0100	[thread overview]
Message-ID: <8135515.T7Z3S40VBb@g550jk> (raw)
In-Reply-To: <028adb9d-e8e7-33db-2aae-028a809a061a@linaro.org>

Hi Neil,

On Mittwoch, 2. November 2022 11:35:55 CET Neil Armstrong wrote:
> Hi,
> 
> On 31/10/2022 18:57, Luca Weiss wrote:
> > The spmi-pmic bindings is now using usb-detect@ for this node, so adjust
> > the example to match.
> 
> Subject should be:
> dt-bindings: pm8941-misc: rename misc node name
> instead of:
> bindings: pm8941-misc: rename misc node name

Also here I've followed the style of the previous commits to this file

4fcdd677c4ea bindings: pm8941-misc: Add support for VBUS detection
dd6f5afb1c2d bindings: pm8941-misc: Convert bindings to YAML

Though it seems other commits in this directory recently have used
"dt-bindings: extcon: " prefix. Do you still want me to change it?

Regards
Luca

> 
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> > 
> >   Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml
> > b/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml index
> > 6a9c96f0352a..fbda899fd260 100644
> > --- a/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml
> > +++ b/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml
> > 
> > @@ -49,7 +49,7 @@ examples:
> >               interrupt-controller;
> >               #interrupt-cells = <4>;
> > 
> > -            usb_id: misc@900 {
> > +            usb_id: usb-detect@900 {
> > 
> >                       compatible = "qcom,pm8941-misc";
> >                       reg = <0x900>;
> >                       interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>;
> 
> With subject fixed:
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>





  reply	other threads:[~2022-11-02 15:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31 17:57 [PATCH 1/3] dt-bindings: mfd: qcom,spmi-pmic: rename extcon node name Luca Weiss
2022-10-31 17:57 ` [PATCH 2/3] bindings: pm8941-misc: rename misc " Luca Weiss
2022-11-02 10:35   ` Neil Armstrong
2022-11-02 15:43     ` Luca Weiss [this message]
2022-11-02 16:28       ` Rob Herring
2022-11-02 16:28   ` Rob Herring
2022-10-31 17:57 ` [PATCH 3/3] ARM: dts: qcom: pm8941: " Luca Weiss
2022-11-02 10:36   ` Neil Armstrong
2022-11-02 16:27 ` [PATCH 1/3] dt-bindings: mfd: qcom,spmi-pmic: rename extcon " Rob Herring
2022-11-07  9:08 ` Lee Jones
2022-11-07 12:49   ` Luca Weiss
2022-11-08  1:27 ` (subset) " Bjorn Andersson
2022-11-16 14:05 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8135515.T7Z3S40VBb@g550jk \
    --to=luca@z3ntu.xyz \
    --cc=afd@ti.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gurus@codeaurora.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=neil.armstrong@linaro.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).