From: Paolo Bonzini <pbonzini@redhat.com>
To: Peng Hao <peng.hao2@zte.com.cn>, shuah@kernel.org, hofsass@google.com
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm: selftests: add -std=gnu99 cflags
Date: Thu, 12 Apr 2018 18:36:04 +0200 [thread overview]
Message-ID: <814c5c74-237a-ec69-c385-feec2d0a38f5@redhat.com> (raw)
In-Reply-To: <1523579790-30773-1-git-send-email-peng.hao2@zte.com.cn>
On 13/04/2018 02:36, Peng Hao wrote:
> lib/kvm_util.c: In function ‘kvm_memcmp_hva_gva’:
> lib/kvm_util.c:332:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
>
> So add -std=gnu99 to CFLAGS
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
> tools/testing/selftests/kvm/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
> index dc44de9..1da541e 100644
> --- a/tools/testing/selftests/kvm/Makefile
> +++ b/tools/testing/selftests/kvm/Makefile
> @@ -14,7 +14,7 @@ LIBKVM += $(LIBKVM_$(UNAME_M))
>
> INSTALL_HDR_PATH = $(top_srcdir)/usr
> LINUX_HDR_PATH = $(INSTALL_HDR_PATH)/include/
> -CFLAGS += -O2 -g -I$(LINUX_HDR_PATH) -Iinclude -I$(<D)
> +CFLAGS += -O2 -g -std=gnu99 -I$(LINUX_HDR_PATH) -Iinclude -I$(<D)
>
> # After inclusion, $(OUTPUT) is defined and
> # $(TEST_GEN_PROGS) starts with $(OUTPUT)/
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2018-04-12 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 0:36 [PATCH] kvm: selftests: add -std=gnu99 cflags Peng Hao
2018-04-12 16:36 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=814c5c74-237a-ec69-c385-feec2d0a38f5@redhat.com \
--to=pbonzini@redhat.com \
--cc=hofsass@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=peng.hao2@zte.com.cn \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).