From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 788FEC3F2C6 for ; Sat, 7 Mar 2020 09:32:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5182B2075A for ; Sat, 7 Mar 2020 09:32:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=xs4all.nl header.i=@xs4all.nl header.b="IElGU+Nn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726134AbgCGJcr (ORCPT ); Sat, 7 Mar 2020 04:32:47 -0500 Received: from lb2-smtp-cloud9.xs4all.net ([194.109.24.26]:40605 "EHLO lb2-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbgCGJcq (ORCPT ); Sat, 7 Mar 2020 04:32:46 -0500 Received: from [IPv6:2001:983:e9a7:1:558f:c736:2117:17d1] ([IPv6:2001:983:e9a7:1:558f:c736:2117:17d1]) by smtp-cloud9.xs4all.net with ESMTPA id AVp4jx1PZ9Im2AVp5jJ1Ey; Sat, 07 Mar 2020 10:32:44 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s1; t=1583573564; bh=qWaLrRMEa0H6bqFO0jtJCqfA8jNFPKhl2ErMRoaoQHw=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=IElGU+NnXTMjTHcDTz3x3maihzMdU9BCsmCqwtlCfQbPKjOtltUN+d2RZubmHKfe0 RkEZwiPlftL5fgaOm4VWKVXnO6uR4k2v9HY/ik63nqs3POHFpSMiZSjlCFErMhe7A5 ccZUIMtgGJQx/A8ScvcaCcVJDdn9qkzbPfpPp+weVNZJW0g5QLJgePQJbFzCx9gTa7 RMJgJLZ0GdlikC5gODepvK9VhoDRI15Tfm3YkD31lXGw62Bw/zqJUqz0NSSTkbrscT eUnN8c+oyD5SwW7OORyS8/2nXp7J+sCsK91j/MxRe3Ckl+sIcOiRF/D8QNzuOUoM07 cy98CrsQAmgRg== Subject: Re: [PATCHv4 10/11] videobuf2: add begin/end cpu_access callbacks to dma-sg To: Sergey Senozhatsky Cc: Hans Verkuil , Tomasz Figa , Mauro Carvalho Chehab , Kyungmin Park , Marek Szyprowski , Sakari Ailus , Laurent Pinchart , Pawel Osciak , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200302041213.27662-1-senozhatsky@chromium.org> <20200302041213.27662-11-senozhatsky@chromium.org> <20200307052628.GB176460@google.com> From: Hans Verkuil Message-ID: <8150bc6c-f6a4-fa2c-4e2e-552dcb168df0@xs4all.nl> Date: Sat, 7 Mar 2020 10:32:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200307052628.GB176460@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfEwhK2PpFlwrt7pMeGwxfncC4Y00enycjjuQwazf0ibd9yUp4vxgG4AvMSJNNj2kB3ed5tB894CI84FMbXT4t5g/2Hgg4XahtISRrM6WeFxwK2Z1DLLw z3FUPumVEVBvHvTr0G1cDpyWdC43q9+frV1Cd0GtaiSTVlgW4yCzsQdjbVSwwjH3S+bT12C4SZHcBs40tgmMTO/Qf5Cij6b8l6DEVTt7WRGLl1PPklPJXlDr 275IJDkjWZ7kbGsHy/BKgnZJzUcX3dkrqWBU0+3DlTXGtjLFSIk8d+7wunDYWM8hxqEYaM2REqrK8MU5oFuPy8dJsydKCX8HowMuQm9rID+qe7R90V6/pN8x 9hKs2bUjf/WtctevvjgoBVQncvbHuvVOdbk5oC9dRLs1Qy+RNyP3t9rnCP/hbDCTn2sfPH4UQTPDX8g6VCTYga4Q4qvWGNP6oDHWRJP2Lau+6Jj7oeyGzMmJ 3u0NeEhSIDAnNbCXPORa650Y3mHy25PHWISggQZB6LM4VOviXReQZEfd8QmnWl0eBNG5fuHf2FfwKm+yXokt/Viw5Euu6zGXpU6Jt6P4eslS2272q+zSi2m9 FPITVQRyvgEJDIf3/7CXKKAwNa+aUpcpiWKU7rA5AeAzbA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/03/2020 06:26, Sergey Senozhatsky wrote: > On (20/03/06 15:04), Hans Verkuil wrote: > [..] >>> + /* >>> + * NOTE: dma-sg allocates memory using the page allocator directly, so >>> + * there is no memory consistency guarantee, hence dma-sg ignores DMA >>> + * attributes passed from the upper layer. That means that >>> + * V4L2_FLAG_MEMORY_NON_CONSISTENT has no effect on dma-sg buffers. >>> + */ >>> buf->pages = kvmalloc_array(buf->num_pages, sizeof(struct page *), >>> GFP_KERNEL | __GFP_ZERO); >>> if (!buf->pages) >>> @@ -470,6 +476,26 @@ static void vb2_dma_sg_dmabuf_ops_release(struct dma_buf *dbuf) >>> vb2_dma_sg_put(dbuf->priv); >>> } >>> >>> +static int vb2_dma_sg_dmabuf_ops_begin_cpu_access(struct dma_buf *dbuf, >>> + enum dma_data_direction direction) >> >> I suggest you use this style to avoid checkpatch warnings: >> >> static int >> vb2_dma_sg_dmabuf_ops_begin_cpu_access(struct dma_buf *dbuf, >> enum dma_data_direction direction) > > OK, will do. > > Just for information, my checkpatch doesn't warn me: > > $ ./scripts/checkpatch.pl outgoing/0010-videobuf2-add-begin-end-cpu_access-callbacks-to-dma-.patch We use the --strict option to checkpatch. Regards, Hans > total: 0 errors, 0 warnings, 46 lines checked > > outgoing/0010-videobuf2-add-begin-end-cpu_access-callbacks-to-dma-.patch has no obvious style problems and is ready for submission. > > -ss >