From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932967AbcHXUom (ORCPT ); Wed, 24 Aug 2016 16:44:42 -0400 Received: from mout.web.de ([212.227.15.3]:55508 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752270AbcHXUok (ORCPT ); Wed, 24 Aug 2016 16:44:40 -0400 To: linuxppc-dev@lists.ozlabs.org, Alexey Kardashevskiy , Alistair Popple , Benjamin Herrenschmidt , Gavin Shan , Ian Munsie , Michael Ellerman , Paul Mackerras , Wei Yang Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Subject: [PATCH] powerpc/powernv/pci: Use kmalloc_array() in two functions Message-ID: <817567b2-cdf6-7f7b-6041-9a026ea10a0f@users.sourceforge.net> Date: Wed, 24 Aug 2016 22:36:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:D6uN2+nP1dHi7XQSvn//0CmkeC4ezARWTRAcp9yKlzV8Ki40HHV MYVzN+ui7z8f+eMI2oDfhRxhGAZj/H41VGg4sQMMVKLGXq3E1xgTdiSNlkXaj8jcqRLi0Wv 5eA0Ia62SyAL7+VtU6Rzv4lmnlGjflU0LIHHOnknYtiaJTKTpyOALgYkc14paMwHCwn4Lsm LzyTAwIVrCOA13YN+2Zkw== X-UI-Out-Filterresults: notjunk:1;V01:K0:GGD0JHAHoUs=:NJ0zwLotbipsKFrumn1GO+ ctHiURSMeJWtcX1pXBBWTbb8KIglZu3MB00/YefoEmEUnT+xHIxBrUGOKtUJLGq341pN4iI6n NMmkLLTlgz7YEft59lLdgsdLUGGDA3+FLWvEqYPZ0v0CWb2hwXP66d02t6kqE1xQOSCvtm/9K GL6zIR8V6XkEcj6SbJsXKc03prnTJoMcPqrky4WF30dJzwzy4naQLtnOVuRxAMUU5d8tjr+/0 q9/EcF/4QSTpF6AfqBBxgUD17j1L0p4W71E3taRbF4GW0r7u78OoeRbJ1lTTi9xt27ZGwNLPb bau7+qwJjU1o74qzGXPeQwVxWbqardxJM5eJ7mJJbr2TepyXCq+LcUP8PxjokYBbeKqRRYoLt pRk1AbgrmmbT5N5ELDgoenRzPKUa2VuvHdpMRYINy0ZXWhx8VFqRWiXyVvD/l4EBklqOjk+ZK WMWzePFxqeZvoinYxc7ydSntghJXyiJPsRXvJl6U5UPTzLzKp+FWvvXi2sN+FjnH2o1wV2Li9 KB1De8pH6qxGv78IHd9y4d7H6RHvimVGuMak4YtOItFtHMxHA3Y8JnMqDz0hO1ThPK6f22Zqt f8WpgCBvVBmmBPyFPEp8A8HePjpPTwcw3FKoYoxGGEOukO6SOS1IuWXkcfuypjjxdYol/z1fb lUO50gT6MfGmhnhxjfCd70JbX1apZzCr6x2VRSK0/ak0IDbG4Iqt+O1xPZnd9bYEP9CEgiBVS F9rS5rZqVkZxUJMbEZPYG1LrRGWXLBfyA3t6bpOJmpeMl9ECt3+RAfNg9LNt1U10PPbT7mdmB E/H1ju/ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 24 Aug 2016 22:26:37 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/powernv/pci-ioda.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c index fd9444f..2366552 100644 --- a/arch/powerpc/platforms/powernv/pci-ioda.c +++ b/arch/powerpc/platforms/powernv/pci-ioda.c @@ -1305,7 +1305,9 @@ static int pnv_pci_vf_assign_m64(struct pci_dev *pdev, u16 num_vfs) else m64_bars = 1; - pdn->m64_map = kmalloc(sizeof(*pdn->m64_map) * m64_bars, GFP_KERNEL); + pdn->m64_map = kmalloc_array(m64_bars, + sizeof(*pdn->m64_map), + GFP_KERNEL); if (!pdn->m64_map) return -ENOMEM; /* Initialize the m64_map to IODA_INVALID_M64 */ @@ -1572,8 +1574,9 @@ int pnv_pci_sriov_enable(struct pci_dev *pdev, u16 num_vfs) /* Allocating pe_num_map */ if (pdn->m64_single_mode) - pdn->pe_num_map = kmalloc(sizeof(*pdn->pe_num_map) * num_vfs, - GFP_KERNEL); + pdn->pe_num_map = kmalloc_array(num_vfs, + sizeof(*pdn->pe_num_map), + GFP_KERNEL); else pdn->pe_num_map = kmalloc(sizeof(*pdn->pe_num_map), GFP_KERNEL); -- 2.9.3