From: Johan Jonker <jbx6244@gmail.com>
To: ezequiel@collabora.com
Cc: boris.brezillon@collabora.com, devicetree@vger.kernel.org,
heiko@sntech.de, hverkuil@xs4all.nl, jonas@kwiboo.se,
kernel@collabora.com, laurent.pinchart@ideasonboard.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-rockchip@lists.infradead.org, nicolas@ndufresne.ca,
paul.kocialkowski@bootlin.com, robh+dt@kernel.org,
sakari.ailus@iki.fi, tfiga@chromium.org
Subject: Re: [PATCH v6 6/6] arm64: dts: rockchip: rk3399: Define the rockchip Video Decoder node
Date: Wed, 26 Feb 2020 13:24:53 +0100 [thread overview]
Message-ID: <817821e3-bc51-8037-b9b9-e429c5eeb280@gmail.com> (raw)
In-Reply-To: <20200220163016.21708-7-ezequiel@collabora.com>
Hi Boris,
Dtsi nodes are sort on address.
The vdec node is now inserted between:
vdec_mmu: iommu @ff660480
vdec : video-codec @ff660000
iep_mmu : iommu @ff670800
This should be:
vpu_mmu : iommu @ff650800
vdec : video-codec @ff660000
vdec_mmu: iommu @ff660480
> From: Boris Brezillon <boris.brezillon at collabora.com>
>
> RK3399 has a Video decoder, define the node in the dtsi. We also add
> the missing power-domain in mmu node and enable the block.
>
> Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
> Signed-off-by: Ezequiel Garcia <ezequiel at collabora.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 33cc21fcf4c1..a07f857df12f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1285,8 +1285,20 @@ vdec_mmu: iommu at ff660480 {
> interrupt-names = "vdec_mmu";
> clocks = <&cru ACLK_VDU>, <&cru HCLK_VDU>;
> clock-names = "aclk", "iface";
> + power-domains = <&power RK3399_PD_VDU>;
> #iommu-cells = <0>;
> - status = "disabled";
> + };
> +
> + vdec: video-codec at ff660000 {
> + compatible = "rockchip,rk3399-vdec";
> + reg = <0x0 0xff660000 0x0 0x400>;
> + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH 0>;
> + interrupt-names = "vdpu";
> + clocks = <&cru ACLK_VDU>, <&cru HCLK_VDU>,
> + <&cru SCLK_VDU_CA>, <&cru SCLK_VDU_CORE>;
> + clock-names = "axi", "ahb", "cabac", "core";
> + power-domains = <&power RK3399_PD_VDU>;
> + iommus = <&vdec_mmu>;
> };
>
> iep_mmu: iommu at ff670800 {
> --
> 2.25.0
next prev parent reply other threads:[~2020-02-26 12:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 16:30 [PATCH v6 0/6] media: rockchip: Add the rkvdec driver Ezequiel Garcia
2020-02-20 16:30 ` [PATCH v6 1/6] media: uapi: h264: Add DPB entry field reference flags Ezequiel Garcia
2020-02-20 16:30 ` [PATCH v6 2/6] media: v4l2-core: Add helpers to build the H264 P/B0/B1 reflists Ezequiel Garcia
2020-03-02 13:24 ` Mauro Carvalho Chehab
2020-03-02 14:44 ` Boris Brezillon
2020-03-02 15:21 ` Mauro Carvalho Chehab
2020-03-05 19:42 ` Nicolas Dufresne
2020-03-05 20:15 ` Boris Brezillon
2020-03-05 21:37 ` Mauro Carvalho Chehab
2020-02-20 16:30 ` [PATCH v6 3/6] media: hantro: h264: Use the generic H264 reflist builder Ezequiel Garcia
2020-02-20 16:30 ` [PATCH v6 4/6] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings Ezequiel Garcia
2020-02-20 16:30 ` [PATCH v6 5/6] media: rkvdec: Add the rkvdec driver Ezequiel Garcia
2020-03-02 13:57 ` Mauro Carvalho Chehab
2020-03-02 14:30 ` Boris Brezillon
2020-03-02 14:53 ` Mauro Carvalho Chehab
2020-03-02 14:35 ` Boris Brezillon
2020-03-02 14:39 ` Mauro Carvalho Chehab
2020-02-20 16:30 ` [PATCH v6 6/6] arm64: dts: rockchip: rk3399: Define the rockchip Video Decoder node Ezequiel Garcia
2020-02-26 12:24 ` Johan Jonker [this message]
2020-02-26 13:21 ` Heiko Stuebner
2020-02-26 17:22 ` Ezequiel Garcia
2020-03-01 0:14 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=817821e3-bc51-8037-b9b9-e429c5eeb280@gmail.com \
--to=jbx6244@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=hverkuil@xs4all.nl \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=nicolas@ndufresne.ca \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).