From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Darren Hart <dvhart@infradead.org>,
platform-driver-x86@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 05/13] i2c: acpi: Return error pointers from i2c_acpi_new_device()
Date: Tue, 27 Nov 2018 20:30:46 +0100 [thread overview]
Message-ID: <81965d66-56fb-01b1-7d5f-63afd5693778@redhat.com> (raw)
In-Reply-To: <20181127192746.GZ10650@smile.fi.intel.com>
Hi,
On 27-11-18 20:27, Andy Shevchenko wrote:
> On Tue, Nov 27, 2018 at 05:14:06PM +0100, Hans de Goede wrote:
>> On 27-11-18 16:37, Andy Shevchenko wrote:
>>> The caller would like to know the reason why the i2c_acpi_new_device() fails.
>>> For example, if adapter is not available, it might be in the future and we
>>> would like to re-probe the clients again. But at the same time we would like to
>>> bail out if the error seems unrecoverable, such as invalid argument supplied.
>>> To achieve this, return error pointer in some cases.
>
>>> acpi_dev_free_resource_list(&resource_list);
>>> - if (ret < 0 || !info->addr)
>>> - return NULL;
>>> + if (!info->addr)
>>> + return ERR_PTR(-EADDRNOTAVAIL);
>>> adapter = i2c_acpi_find_adapter_by_handle(lookup.adapter_handle);
>>> if (!adapter)
>>> - return NULL;
>>> + return ERR_PTR(-ENODEV);
>
>> Why not simply return -EPROBE_DEFER here (and simplify the callers a lot).
>
>> This is the only case where we really want to defer.
>
>>> + client = i2c_new_device(adapter, info);
>>> + if (!client)
>>> + return ERR_PTR(-ENODEV);
>>
>> If you look at i2c_new_device, it can fail because it is
>> out of memory, the i2c slave address is invalid, or
>> their already is an i2c slave with the same address,
>> iow if this were to return an ERR_PTR itself, this
>> would return -ENOMEM, -EINVAL or -EBUSY and never
>> -EPROBE_DEFER.
>
> It would change the behaviour.
Yes it would change behaviour, for the better, all the errors
from i2c_new_device() (*) will not go away when we retry later,
so responding with probe-deferring to them is not useful.
> In any case, it's only two users and both written by you, so, just to be sure
> you aware of this change and bless it.
I'm aware and you've my ack for this change.
Regards,
Hans
*) with exception of -ENOMEM which should never happen
next prev parent reply other threads:[~2018-11-27 19:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 15:37 [PATCH v3 00/13] i2c-multi-instantiate: Adapt for INT3515 and alike Andy Shevchenko
2018-11-27 15:37 ` [PATCH v3 02/13] platform/x86: intel_cht_int33fe: Accept errors of i2c_acpi_new_device() Andy Shevchenko
2018-11-27 15:37 ` [PATCH v3 03/13] platform/x86: i2c-multi-instantiate: " Andy Shevchenko
2018-11-27 15:37 ` [PATCH v3 04/13] platform/x86: i2c-multi-instantiate: Defer probe when no adapter found Andy Shevchenko
2018-11-27 15:37 ` [PATCH v3 05/13] i2c: acpi: Return error pointers from i2c_acpi_new_device() Andy Shevchenko
2018-11-27 16:14 ` Hans de Goede
2018-11-27 16:16 ` Hans de Goede
2018-11-27 19:27 ` Andy Shevchenko
2018-11-27 19:30 ` Hans de Goede [this message]
2018-11-27 15:37 ` [PATCH v3 06/13] i2c: acpi: Use ACPI_FAILURE instead of !ACPI_SUCCESS Andy Shevchenko
2018-11-27 15:37 ` [PATCH v3 07/13] i2c: acpi: Introduce i2c_acpi_get_i2c_resource() helper Andy Shevchenko
2018-11-27 15:37 ` [PATCH v3 08/13] platform/x86: i2c-multi-instantiate: Count I2cSerialBus() resources Andy Shevchenko
2018-11-27 15:37 ` [PATCH v3 09/13] platform/x86: i2c-multi-instantiate: Distinguish IRQ resource type Andy Shevchenko
2018-11-27 15:37 ` [PATCH v3 10/13] platform/x86: i2c-multi-instantiate: Introduce IOAPIC IRQ support Andy Shevchenko
2018-11-27 15:37 ` [PATCH v3 11/13] platform/x86: i2c-multi-instantiate: Allow to have same slaves Andy Shevchenko
2018-11-27 15:37 ` [PATCH v3 12/13] ACPI / scan: Create platform device for INT3515 ACPI nodes Andy Shevchenko
2018-11-27 15:37 ` [PATCH v3 13/13] iio: inv_mpu6050: Use i2c_acpi_get_i2c_resource() helper Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81965d66-56fb-01b1-7d5f-63afd5693778@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).