From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935224AbdHYWDH (ORCPT ); Fri, 25 Aug 2017 18:03:07 -0400 Received: from mail-sn1nam01on0064.outbound.protection.outlook.com ([104.47.32.64]:44400 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932585AbdHYWDD (ORCPT ); Fri, 25 Aug 2017 18:03:03 -0400 From: Nadav Amit To: "mike.kravetz@oracle.com" , "ebiggers@google.com" CC: Andrew Morton , Andrea Arcangeli , Dmitry Vyukov , Hugh Dickins , Minchan Kim , "rientjes@google.com" , "stable@vger.kernel.org" , "mm-commits@vger.kernel.org" , "open list:MEMORY MANAGEMENT" , Linux Kernel Mailing List , Michal Hocko , "nyc@holomorphy.com" Subject: Re: + mm-madvise-fix-freeing-of-locked-page-with-madv_free.patch added to -mm tree Thread-Topic: + mm-madvise-fix-freeing-of-locked-page-with-madv_free.patch added to -mm tree Thread-Index: AQHTHe3pGDFw25nGQky3QTGbuZcshQ== Date: Fri, 25 Aug 2017 22:02:57 +0000 Message-ID: <81C11D6F-653D-4B14-A3A6-E6BB6FB5436D@vmware.com> References: <599df681.NreP1dR3/HGSfpCe%akpm@linux-foundation.org> <20170824060957.GA29811@dhcp22.suse.cz> In-Reply-To: <20170824060957.GA29811@dhcp22.suse.cz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=namit@vmware.com; x-originating-ip: [208.91.2.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY2PR05MB045;20:8T6EKc1Ev9MrnAlhXiXnPrBX7DzdNX8VNIvZjVH+pj+taC3kSRJ1bIF3+hZSJ0jQb0cGIsrlx7xCqUjEcLt8zdiUVA+Gife3bYcZOkdY04FaLaHoJksuB62qK7YRwK/Inu2ZcrNuWzihJpe7CqpVdY4O0NkcwOO6aEdWQMo34Y4= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 0ae3bb8a-8a74-4f57-df59-08d4ec050bad x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BY2PR05MB045; x-exchange-antispam-report-test: UriScan:(211936372134217)(153496737603132); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(920507026)(6041248)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR05MB045;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR05MB045; x-forefront-prvs: 041032FF37 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(377424004)(24454002)(199003)(50986999)(4326008)(36756003)(6116002)(5660300001)(189998001)(2950100002)(478600001)(102836003)(86362001)(76176999)(83716003)(34040400001)(2906002)(7416002)(6436002)(25786009)(229853002)(8936002)(8676002)(2900100001)(33656002)(6512007)(105586002)(6246003)(7736002)(14454004)(106356001)(68736007)(305945005)(230783001)(6506006)(82746002)(81156014)(66066001)(53936002)(3846002)(81166006)(54906002)(6486002)(99286003)(3660700001)(77096006)(2501003)(97736004)(3280700002)(54356999)(101416001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR05MB045;H:BY2PR05MB2215.namprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Aug 2017 22:02:57.8205 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR05MB045 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7PM3AQ6029182 Michal Hocko wrote: > Hmm, I do not see this neither in linux-mm nor LKML. Strange > > On Wed 23-08-17 14:41:21, Andrew Morton wrote: >> From: Eric Biggers >> Subject: mm/madvise.c: fix freeing of locked page with MADV_FREE >> >> If madvise(..., MADV_FREE) split a transparent hugepage, it called >> put_page() before unlock_page(). This was wrong because put_page() can >> free the page, e.g. if a concurrent madvise(..., MADV_DONTNEED) has >> removed it from the memory mapping. put_page() then rightfully complained >> about freeing a locked page. >> >> Fix this by moving the unlock_page() before put_page(). Quick grep shows that a similar flow (put_page() followed by an unlock_page() ) also happens in hugetlbfs_fallocate(). Isn’t it a problem as well?