From: Arseny Krasnov <arseny.krasnov@kaspersky.com>
To: Stefan Hajnoczi <stefanha@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Andra Paraschiv <andraprs@amazon.com>,
Norbert Slusarek <nslusarek@gmx.net>,
Colin Ian King <colin.king@canonical.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"oxffffaa@gmail.com" <oxffffaa@gmail.com>
Subject: Re: [RFC PATCH v2 0/6] Improve SOCK_SEQPACKET receive logic
Date: Sun, 4 Jul 2021 11:13:35 +0300 [thread overview]
Message-ID: <81acbbf0-6886-7348-c4f8-06bb2f1419d2@kaspersky.com> (raw)
In-Reply-To: <20210704080820.88746-1-arseny.krasnov@kaspersky.com>
On 04.07.2021 11:08, Arseny Krasnov wrote:
> This patchset modifies receive logic for SOCK_SEQPACKET.
> Difference between current implementation and this version is that
> now reader is woken up when there is at least one RW packet in rx
> queue of socket and data is copied to user's buffer, while merged
> approach wake up user only when whole message is received and kept
> in queue. New implementation has several advantages:
> 1) There is no limit for message length. Merged approach requires
> that length must be smaller than 'peer_buf_alloc', otherwise
> transmission will stuck.
> 2) There is no need to keep whole message in queue, thus no
> 'kmalloc()' memory will be wasted until EOR is received.
>
> Also new approach has some feature: as fragments of message
> are copied until EOR is received, it is possible that part of
> message will be already in user's buffer, while rest of message
> still not received. And if user will be interrupted by signal or
> timeout with part of message in buffer, it will exit receive loop,
> leaving rest of message in queue. To solve this problem special
> callback was added to transport: it is called when user was forced
> to leave exit loop and tells transport to drop any packet until
> EOR met. When EOR is found, this mode is disabled and normal packet
> processing started. Note, that when 'drop until EOR' mode is on,
> incoming packets still inserted in queue, reader will be woken up,
> tries to copy data, but nothing will be copied until EOR found.
> It was possible to drain such unneeded packets it rx work without
> kicking user, but implemented way is simplest. Anyway, i think
> such cases are rare.
>
> New test also added - it tries to copy to invalid user's
> buffer.
>
> Arseny Krasnov (16):
> af_vsock/virtio/vsock: change seqpacket receive logic
> af_vsock/virtio/vsock: remove 'seqpacket_has_data' callback
> virtio/vsock: remove 'msg_count' based logic
> af_vsock/virtio/vsock: add 'seqpacket_drop()' callback
> virtio/vsock: remove record size limit for SEQPACKET
> vsock_test: SEQPACKET read to broken buffer
>
> drivers/vhost/vsock.c | 2 +-
> include/linux/virtio_vsock.h | 7 +-
> include/net/af_vsock.h | 4 +-
> net/vmw_vsock/af_vsock.c | 44 ++++----
> net/vmw_vsock/virtio_transport.c | 2 +-
> net/vmw_vsock/virtio_transport_common.c | 103 ++++++++-----------
> net/vmw_vsock/vsock_loopback.c | 2 +-
> tools/testing/vsock/vsock_test.c | 120 ++++++++++++++++++++++
> 8 files changed, 193 insertions(+), 91 deletions(-)
>
> v1 -> v2:
> Patches reordered and reorganized.
>
> Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>
> ---
> cv.txt | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> create mode 100644 cv.txt
>
> diff --git a/cv.txt b/cv.txt
> new file mode 100644
> index 000000000000..e69de29bb2d1
Sorry, forget to remove my tmp file
next prev parent reply other threads:[~2021-07-04 8:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 8:08 [RFC PATCH v2 0/6] Improve SOCK_SEQPACKET receive logic Arseny Krasnov
2021-07-04 8:09 ` [RFC PATCH v2 1/6] af_vsock/virtio/vsock: change seqpacket " Arseny Krasnov
2021-07-04 8:10 ` [RFC PATCH v2 2/6] af_vsock/virtio/vsock: remove 'seqpacket_has_data' callback Arseny Krasnov
2021-07-04 8:10 ` [RFC PATCH v2 3/6] virtio/vsock: remove 'msg_count' based logic Arseny Krasnov
2021-07-04 8:10 ` [RFC PATCH v2 4/6] af_vsock/virtio/vsock: add 'seqpacket_drop()' callback Arseny Krasnov
2021-07-04 8:10 ` [RFC PATCH v2 5/6] virtio/vsock: remove record size limit for SEQPACKET Arseny Krasnov
2021-07-04 8:11 ` [RFC PATCH v2 6/6] vsock_test: SEQPACKET read to broken buffer Arseny Krasnov
2021-07-04 8:13 ` Arseny Krasnov [this message]
2021-07-04 8:30 ` [RFC PATCH v2 0/6] Improve SOCK_SEQPACKET receive logic Michael S. Tsirkin
2021-07-04 9:23 ` Arseny Krasnov
2021-07-04 9:54 ` Michael S. Tsirkin
2021-07-05 10:48 ` [MASSMAIL KLMS]Re: " Arseny Krasnov
2021-07-05 15:23 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81acbbf0-6886-7348-c4f8-06bb2f1419d2@kaspersky.com \
--to=arseny.krasnov@kaspersky.com \
--cc=andraprs@amazon.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nslusarek@gmx.net \
--cc=oxffffaa@gmail.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).