From: Shuah Khan <skhan@linuxfoundation.org>
To: Joe Perches <joe@perches.com>,
Julia Lawall <julia.lawall@inria.fr>,
Dan Carpenter <dan.carpenter@oracle.com>,
Shuah Khan <shuah@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "Ard Biesheuvel" <ardb@kernel.org>,
linux-iio@vger.kernel.org, drbd-dev@tron.linbit.com,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"David Lechner" <david@lechnology.com>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>,
linux-amlogic@lists.infradead.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
openipmi-developer@lists.sourceforge.net,
linux-clk@vger.kernel.org,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Jerome Brunet" <jbrunet@baylibre.com>
Subject: Re: [PATCH 00/18] use semicolons rather than commas to separate statements
Date: Fri, 2 Oct 2020 10:47:13 -0600 [thread overview]
Message-ID: <81b94c3a-43d6-c9f5-0bc0-43bf65b3d5fc@linuxfoundation.org> (raw)
In-Reply-To: <cd75e2d1-9923-b725-78cd-fd5611431584@linuxfoundation.org>
On 9/29/20 7:42 AM, Shuah Khan wrote:
> On 9/29/20 7:34 AM, Joe Perches wrote:
>> On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote:
>>> On Tue, 29 Sep 2020, Dan Carpenter wrote:
>>>> The times where commas are used deliberately to replace curly braces
>>>> are
>>>> just evil. Either way the code is cleaner with semi-colons.
>>>
>>> I also found exaamples like the following to be particularly unforunate:
>>>
>>> fprintf(stderr,
>>> "page_nr %lu wrong count %Lu
>>> %Lu\n",
>>> page_nr, count,
>>> count_verify[page_nr]), exit(1);
>>>
>>> The exit is very hard to see, unless you know to look for it.
>>
>> I sent that patch last month.
>> https://patchwork.kernel.org/patch/11734877/
>>
>
> I see what happened. This patch touches lib, cpupower, and selftests.
> Guess lost in the limbo of who takes it.
>
> tools/lib/subcmd/help.c | 10 +-
> tools/power/cpupower/utils/cpufreq-set.c | 14 +-
> tools/testing/selftests/vm/gup_benchmark.c | 18 +-
> tools/testing/selftests/vm/userfaultfd.c | 296 +++++++++++++--------
> 4 files changed, 210 insertions(+), 128 deletions(-)
>
> I can take it through one of my trees.
>
Rafael, Andrew,
This patch is now applied to
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
fixes branch.
This spans pm, kselftest-mm tests and tools/lib and has been
in limbo for a few weeks for that reason.
I decided to take this through kselftest tree to avoid having
Joe split the patches.
thanks,
-- Shuah
prev parent reply other threads:[~2020-10-02 16:47 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 19:12 [PATCH 00/18] use semicolons rather than commas to separate statements Julia Lawall
2020-09-27 19:12 ` [PATCH 01/18] clk: uniphier: " Julia Lawall
2020-10-14 0:44 ` Stephen Boyd
2020-09-27 19:12 ` [PATCH 02/18] ipmi:bt-bmc: " Julia Lawall
2020-09-27 19:12 ` [PATCH 03/18] [ARM] pata_icside: " Julia Lawall
2020-09-28 16:47 ` Joe Perches
2020-09-28 17:11 ` Julia Lawall
2020-09-28 17:57 ` Joe Perches
2020-09-27 19:12 ` [PATCH 04/18] hwrng: stm32 - " Julia Lawall
2020-10-02 11:55 ` Herbert Xu
2020-09-27 19:12 ` [PATCH 05/18] bcma: " Julia Lawall
2020-10-01 13:24 ` Kalle Valo
2020-09-27 19:12 ` [PATCH 06/18] hwrng: iproc-rng200 - " Julia Lawall
2020-09-28 1:42 ` Florian Fainelli
2020-10-02 11:55 ` Herbert Xu
2020-09-27 19:12 ` [PATCH 07/18] hwrng: mxc-rnga " Julia Lawall
2020-10-02 11:55 ` Herbert Xu
2020-09-27 19:12 ` [PATCH 08/18] agp: " Julia Lawall
2020-09-27 19:12 ` [PATCH 09/18] clk: mvebu: ap80x-cpu: " Julia Lawall
2020-10-14 0:44 ` Stephen Boyd
2020-09-27 19:12 ` [PATCH 10/18] clk: meson: " Julia Lawall
2020-09-28 9:47 ` Jerome Brunet
2020-10-08 1:54 ` Stephen Boyd
2020-10-14 0:44 ` Stephen Boyd
2020-09-27 19:12 ` [PATCH 11/18] clocksource/drivers/mps2-timer: " Julia Lawall
2020-10-01 8:13 ` [tip: timers/core] clocksource/drivers/mps2-timer: Use " tip-bot2 for Julia Lawall
2020-09-27 19:12 ` [PATCH 12/18] ACPI: use " Julia Lawall
2020-09-27 20:27 ` Christophe JAILLET
2020-09-27 19:12 ` [PATCH 13/18] crypto: " Julia Lawall
2020-10-02 11:56 ` Herbert Xu
2020-09-27 19:12 ` [PATCH 14/18] regmap: debugfs: " Julia Lawall
2020-09-27 19:12 ` [PATCH 15/18] counter: " Julia Lawall
2020-09-28 15:37 ` David Lechner
2020-09-29 15:27 ` Jonathan Cameron
2020-09-27 19:12 ` [PATCH 16/18] clocksource/drivers: " Julia Lawall
2020-10-02 14:29 ` [tip: timers/core] clocksource/drivers/armada-370-xp: Use " tip-bot2 for Julia Lawall
2020-09-27 19:12 ` [PATCH 17/18] crypto: atmel-tdes - use " Julia Lawall
2020-10-02 11:56 ` Herbert Xu
2020-09-27 19:12 ` [PATCH 18/18] drbd: " Julia Lawall
2020-09-27 20:08 ` [PATCH 00/18] " Joe Perches
[not found] ` <160132172369.55460.9237357219623604216.b4-ty@kernel.org>
2020-09-29 0:45 ` Joe Perches
2020-09-29 11:37 ` Mark Brown
2020-09-29 11:46 ` Julia Lawall
2020-09-29 12:37 ` Mark Brown
2020-09-29 12:44 ` Julia Lawall
2020-09-30 19:33 ` Joe Perches
2020-10-01 11:01 ` Mark Brown
2020-10-03 18:40 ` Joe Perches
2020-10-03 19:15 ` Konstantin Ryabitsev
2020-10-03 19:18 ` Julia Lawall
2020-10-03 19:31 ` Konstantin Ryabitsev
2020-10-03 19:43 ` Joe Perches
2020-10-05 16:52 ` Mark Brown
2020-10-03 19:27 ` Joe Perches
2020-10-03 19:36 ` Joe Perches
2020-09-29 12:20 ` Ard Biesheuvel
2020-09-29 12:36 ` Julia Lawall
2020-09-29 12:41 ` Dan Carpenter
2020-09-29 12:47 ` Julia Lawall
2020-09-29 13:34 ` Joe Perches
2020-09-29 13:42 ` Julia Lawall
2020-09-29 13:42 ` Shuah Khan
2020-10-02 16:47 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b94c3a-43d6-c9f5-0bc0-43bf65b3d5fc@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=david@lechnology.com \
--cc=drbd-dev@tron.linbit.com \
--cc=jbrunet@baylibre.com \
--cc=joe@perches.com \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=rafael@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).