From: Matthias Brugger <matthias.bgg@gmail.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Kevin Hilman <khilman@kernel.org>
Cc: Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] [RFC] soc: mediatek: Use GENPD_FLAG_ACTIVE_WAKEUP
Date: Thu, 2 Nov 2017 12:32:10 +0100 [thread overview]
Message-ID: <81cf254c-66b9-a139-0344-81c5cb560f88@gmail.com> (raw)
In-Reply-To: <1509473494-19740-4-git-send-email-geert+renesas@glider.be>
On 10/31/2017 07:11 PM, Geert Uytterhoeven wrote:
> Set the newly introduced GENPD_FLAG_ACTIVE_WAKEUP, which allows to
> remove the driver's own flag-based callback.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This must not be applied before "PM / Domain: Enable genpd users to
> specify default active wakeup behavior" has landed upstream, hence the
> "RFC".
>
> Compile-tested only.
>
> v2:
> - New.
> ---
> drivers/soc/mediatek/mtk-scpsys.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
> diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c
> index e1ce8b1b5090aa0a..e570b6af2e6ffbdd 100644
> --- a/drivers/soc/mediatek/mtk-scpsys.c
> +++ b/drivers/soc/mediatek/mtk-scpsys.c
> @@ -361,17 +361,6 @@ static int scpsys_power_off(struct generic_pm_domain *genpd)
> return ret;
> }
>
> -static bool scpsys_active_wakeup(struct device *dev)
> -{
> - struct generic_pm_domain *genpd;
> - struct scp_domain *scpd;
> -
> - genpd = pd_to_genpd(dev->pm_domain);
> - scpd = container_of(genpd, struct scp_domain, genpd);
> -
> - return scpd->data->active_wakeup;
> -}
> -
> static void init_clks(struct platform_device *pdev, struct clk **clk)
> {
> int i;
> @@ -466,7 +455,8 @@ static struct scp *init_scp(struct platform_device *pdev,
> genpd->name = data->name;
> genpd->power_off = scpsys_power_off;
> genpd->power_on = scpsys_power_on;
> - genpd->dev_ops.active_wakeup = scpsys_active_wakeup;
> + if (scpd->data->active_wakeup)
> + genpd->flags |= GENPD_FLAG_ACTIVE_WAKEUP;
> }
>
> return scp;
>
next prev parent reply other threads:[~2017-11-02 11:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 18:11 [PATCH v2 0/5] PM / Domains: Remove gpd_dev_ops.active_wakeup() callback Geert Uytterhoeven
2017-10-31 18:11 ` [PATCH v2 1/5] PM / Domains: Allow genpd users to specify default active wakeup behavior Geert Uytterhoeven
2017-11-02 13:59 ` Kevin Hilman
2017-10-31 18:11 ` [PATCH v2 2/5] [RFC] ARM: shmobile: pm-rmobile: Use GENPD_FLAG_ACTIVE_WAKEUP Geert Uytterhoeven
2017-11-02 8:18 ` Simon Horman
2017-10-31 18:11 ` [PATCH v2 3/5] [RFC] soc: mediatek: " Geert Uytterhoeven
2017-11-02 11:32 ` Matthias Brugger [this message]
2017-10-31 18:11 ` [PATCH v2 4/5] [RFC] soc: rockchip: power-domain: " Geert Uytterhoeven
2017-11-02 9:51 ` Heiko Stübner
2017-10-31 18:11 ` [PATCH v2 5/5] [RFC] PM / Domains: Remove gpd_dev_ops.active_wakeup() callback Geert Uytterhoeven
2017-11-02 14:00 ` Kevin Hilman
2017-11-01 10:10 ` [PATCH v2 0/5] " Ulf Hansson
2017-11-02 9:14 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81cf254c-66b9-a139-0344-81c5cb560f88@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=horms@verge.net.au \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=magnus.damm@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).