* [PATCH -next] usbip: simplify the return expression of usbip_core_init()
@ 2020-09-15 3:26 Liu Shixin
2020-09-15 16:37 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Liu Shixin @ 2020-09-15 3:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Valentina Manea, Shuah Khan
Cc: linux-usb, linux-kernel, Liu Shixin
Simplify the return expression.
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
---
drivers/usb/usbip/usbip_common.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/usb/usbip/usbip_common.c b/drivers/usb/usbip/usbip_common.c
index e4b96674c405..4ce6c6a45eb1 100644
--- a/drivers/usb/usbip/usbip_common.c
+++ b/drivers/usb/usbip/usbip_common.c
@@ -755,13 +755,7 @@ EXPORT_SYMBOL_GPL(usbip_recv_xbuff);
static int __init usbip_core_init(void)
{
- int ret;
-
- ret = usbip_init_eh();
- if (ret)
- return ret;
-
- return 0;
+ return usbip_init_eh();
}
static void __exit usbip_core_exit(void)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] usbip: simplify the return expression of usbip_core_init()
2020-09-15 3:26 [PATCH -next] usbip: simplify the return expression of usbip_core_init() Liu Shixin
@ 2020-09-15 16:37 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2020-09-15 16:37 UTC (permalink / raw)
To: Liu Shixin, Greg Kroah-Hartman, Valentina Manea, Shuah Khan
Cc: linux-usb, linux-kernel, Shuah Khan
On 9/14/20 9:26 PM, Liu Shixin wrote:
> Simplify the return expression.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
> drivers/usb/usbip/usbip_common.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/usb/usbip/usbip_common.c b/drivers/usb/usbip/usbip_common.c
> index e4b96674c405..4ce6c6a45eb1 100644
> --- a/drivers/usb/usbip/usbip_common.c
> +++ b/drivers/usb/usbip/usbip_common.c
> @@ -755,13 +755,7 @@ EXPORT_SYMBOL_GPL(usbip_recv_xbuff);
>
> static int __init usbip_core_init(void)
> {
> - int ret;
> -
> - ret = usbip_init_eh();
> - if (ret)
> - return ret;
> -
> - return 0;
> + return usbip_init_eh();
> }
>
> static void __exit usbip_core_exit(void)
>
Looks good to me.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-15 22:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 3:26 [PATCH -next] usbip: simplify the return expression of usbip_core_init() Liu Shixin
2020-09-15 16:37 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).