From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>
Cc: "mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: bd718x7: Yamlify and add BD71850
Date: Wed, 8 Jan 2020 08:38:42 +0000 [thread overview]
Message-ID: <821646c01d3efbba1eaabc7f5da8048fe4f25bbd.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <CAL_JsqJzaS1G-ODb4A5QGdhhJ+SXXYPY0nXvKfJnZKoRP+WmAA@mail.gmail.com>
Hi de Ho Peeps,
On Tue, 2020-01-07 at 09:37 -0600, Rob Herring wrote:
> On Tue, Jan 7, 2020 at 7:01 AM Lee Jones <lee.jones@linaro.org>
> wrote:
> > On Fri, 27 Dec 2019, Matti Vaittinen wrote:
> >
> > > Convert ROHM bd71837 and bd71847 PMIC binding text docs to yaml.
> > > Split
> > > the binding document to two separate documents (own documents for
> > > BD71837
> > > and BD71847) as they have different amount of regulators. This
> > > way we can
> > > better enforce the node name check for regulators. ROHM is also
> > > providing
> > > BD71850 - which is almost identical to BD71847 - main difference
> > > is some
> > > initial regulator states. The BD71850 can be driven by same
> > > driver and it
> > > has same buck/LDO setup as BD71847 - add it to BD71847 binding
> > > document and
> > > introduce compatible for it.
> > >
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com
> > > >
> > > ---
> > >
> > > changes since v1:
> > > - constrains to short and long presses.
> > > - reworded commit message to shorten a line exceeding 75 chars
> > > - added 'additionalProperties: false'
> > > - removed 'clock-names' from example node
> > >
> > > .../bindings/mfd/rohm,bd71837-pmic.txt | 90 -------
> > > .../bindings/mfd/rohm,bd71837-pmic.yaml | 236
> > > ++++++++++++++++++
> > > .../bindings/mfd/rohm,bd71847-pmic.yaml | 222
> > > ++++++++++++++++
> > > .../regulator/rohm,bd71837-regulator.txt | 162 ------------
> > > .../regulator/rohm,bd71837-regulator.yaml | 103 ++++++++
> > > .../regulator/rohm,bd71847-regulator.yaml | 97 +++++++
> >
> > Can you split these out per-subsystem, so that I can apply the MFD
> > changes please?
>
> That's not going to work any more. The MFD binding references the
> child bindings and the complete example(s) resides in the MFD
> binding.
So is it Ok to take all of these in MFD tree - or how should this be
done? Can Rob get them in after acks from Lee/Mark?
Br,
Matti Vaittinen
next prev parent reply other threads:[~2020-01-08 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 11:12 [PATCH v2] dt-bindings: bd718x7: Yamlify and add BD71850 Matti Vaittinen
2019-12-30 17:55 ` Rob Herring
2020-01-07 13:01 ` Lee Jones
2020-01-07 15:37 ` Rob Herring
2020-01-08 8:38 ` Vaittinen, Matti [this message]
2020-01-13 10:49 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=821646c01d3efbba1eaabc7f5da8048fe4f25bbd.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).