From: Dmitry Osipenko <digetx@gmail.com>
To: "Randy Dunlap" <rdunlap@infradead.org>,
"Jens Axboe" <axboe@kernel.dk>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"David Heidelberg" <david@ixit.cz>,
"Peter Geis" <pgwipeout@gmail.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Nicolas Chauvet" <kwizart@gmail.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Billy Laws" <blaws05@gmail.com>,
"Nils Östlund" <nils@naltan.com>,
"Christoph Hellwig" <hch@infradead.org>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Davidlohr Bueso" <dave@stgolabs.net>
Cc: linux-tegra@vger.kernel.org, linux-block@vger.kernel.org,
Andrey Danin <danindrey@mail.ru>,
Gilles Grandou <gilles@grandou.net>,
Ryan Grachek <ryan@edited.us>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-efi <linux-efi@vger.kernel.org>
Subject: Re: [PATCH v4 3/6] partitions: Introduce NVIDIA Tegra Partition Table
Date: Fri, 15 May 2020 05:02:40 +0300 [thread overview]
Message-ID: <821ae388-07b2-5883-95b8-c551ddc7bdea@gmail.com> (raw)
In-Reply-To: <055fc187-6181-6ccb-04a8-ab4324270ed7@infradead.org>
15.05.2020 04:58, Randy Dunlap пишет:
> On 5/14/20 6:41 PM, Dmitry Osipenko wrote:
>> diff --git a/block/partitions/Kconfig b/block/partitions/Kconfig
>> index 702689a628f0..2c1408cba1a6 100644
>> --- a/block/partitions/Kconfig
>> +++ b/block/partitions/Kconfig
>> @@ -268,3 +268,11 @@ config CMDLINE_PARTITION
>> help
>> Say Y here if you want to read the partition table from bootargs.
>> The format for the command line is just like mtdparts.
>> +
>> +config TEGRA_PARTITION
>> + bool "NVIDIA Tegra Partition support" if PARTITION_ADVANCED
>> + default y if ARCH_TEGRA
>> + depends on (ARCH_TEGRA && MMC_BLOCK) || COMPILE_TEST
>
> That looks odd. Such depends are more often like:
> depends on MMC_BLOCK && (ARCH_TEGRA || COMPILE_TEST)
>
> but that's just my experience. If this works when ARCH_TEGRA and MMC_BLOCK
> are not set and COMPILE_TEST is set, that's fine.
Ah, right! It shouldn't work since mmc_bdev_to_card() will be undefined
if MMC_BLOCK=n. Good catch, thank you! :)
next prev parent reply other threads:[~2020-05-15 2:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 1:41 [PATCH v4 0/6] Introduce NVIDIA Tegra Partition Table Dmitry Osipenko
2020-05-15 1:41 ` [PATCH v4 1/6] mmc: core: Add raw_boot_mult field to mmc_ext_csd Dmitry Osipenko
2020-05-15 1:41 ` [PATCH v4 2/6] mmc: block: Add mmc_bdev_to_card() helper Dmitry Osipenko
2020-05-15 1:41 ` [PATCH v4 3/6] partitions: Introduce NVIDIA Tegra Partition Table Dmitry Osipenko
2020-05-15 1:58 ` Randy Dunlap
2020-05-15 2:02 ` Dmitry Osipenko [this message]
2020-05-15 1:41 ` [PATCH v4 4/6] partitions/efi: Support GPT entry lookup at a non-standard location Dmitry Osipenko
2020-05-15 10:03 ` Steve McIntyre
2020-05-15 15:52 ` Dmitry Osipenko
2020-05-15 1:41 ` [PATCH v4 5/6] partitions/tegra: Support gpt_sector= command line option Dmitry Osipenko
2020-05-15 1:41 ` [PATCH v4 6/6] soc/tegra: Expose Boot Configuration Table via sysfs Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=821ae388-07b2-5883-95b8-c551ddc7bdea@gmail.com \
--to=digetx@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=axboe@kernel.dk \
--cc=blaws05@gmail.com \
--cc=danindrey@mail.ru \
--cc=dave@stgolabs.net \
--cc=david@ixit.cz \
--cc=gilles@grandou.net \
--cc=hch@infradead.org \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=nils@naltan.com \
--cc=pgwipeout@gmail.com \
--cc=rdunlap@infradead.org \
--cc=ryan@edited.us \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).