From: "Christian König" <easy2remember.chk@googlemail.com>
To: "Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
Julia Lawall <julia.lawall@lip6.fr>
Cc: "kbuild-all@01.org" <kbuild-all@01.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Gustavo Padovan <gustavo@padovan.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: fix call_kern.cocci warnings (fwd)
Date: Thu, 25 Oct 2018 08:53:21 +0200 [thread overview]
Message-ID: <823eb7cc-ba7e-b816-1821-c73dfd4c70bf@googlemail.com> (raw)
In-Reply-To: <BY1PR12MB05028BA16A21896179679800B4F70@BY1PR12MB0502.namprd12.prod.outlook.com>
Am 25.10.18 um 03:28 schrieb Zhou, David(ChunMing):
> Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
NAK, GFP_ATOMIC should be avoided.
The correct solution is to move the allocation out of the spinlock or
drop the lock and reacquire.
Christian.
>
>> -----Original Message-----
>> From: Julia Lawall <julia.lawall@lip6.fr>
>> Sent: Thursday, October 25, 2018 2:57 AM
>> To: Zhou, David(ChunMing) <David1.Zhou@amd.com>
>> Cc: kbuild-all@01.org; intel-gfx@lists.freedesktop.org; dri-
>> devel@lists.freedesktop.org; Christian König
>> <easy2remember.chk@googlemail.com>; Gustavo Padovan
>> <gustavo@padovan.org>; Maarten Lankhorst
>> <maarten.lankhorst@linux.intel.com>; Sean Paul <sean@poorly.run>; David
>> Airlie <airlied@linux.ie>; dri-devel@lists.freedesktop.org; linux-
>> kernel@vger.kernel.org
>> Subject: [PATCH] drm: fix call_kern.cocci warnings (fwd)
>>
>> The containing function is called with a spin_lock held, so GFP_KERNEL can't
>> be used.
>>
>> julia
>>
>> ---------- Forwarded message ----------
>> Date: Tue, 23 Oct 2018 17:14:25 +0800
>> From: kbuild test robot <lkp@intel.com>
>> To: kbuild@01.org
>> Cc: Julia Lawall <julia.lawall@lip6.fr>
>> Subject: [PATCH] drm: fix call_kern.cocci warnings
>>
>> CC: kbuild-all@01.org
>> CC: intel-gfx@lists.freedesktop.org
>> CC: dri-devel@lists.freedesktop.org
>> TO: Chunming Zhou <david1.zhou@amd.com>
>> CC: "Christian König" <easy2remember.chk@googlemail.com>
>> CC: Gustavo Padovan <gustavo@padovan.org>
>> CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> CC: Sean Paul <sean@poorly.run>
>> CC: David Airlie <airlied@linux.ie>
>> CC: dri-devel@lists.freedesktop.org
>> CC: linux-kernel@vger.kernel.org
>>
>> From: kbuild test robot <fengguang.wu@intel.com>
>>
>> drivers/gpu/drm/drm_syncobj.c:202:4-14: ERROR: function
>> drm_syncobj_find_signal_pt_for_point called on line 390 inside lock on line
>> 389 but uses GFP_KERNEL
>>
>> Find functions that refer to GFP_KERNEL but are called with locks held.
>>
>> Semantic patch information:
>> The proposed change of converting the GFP_KERNEL is not necessarily the
>> correct one. It may be desired to unlock the lock, or to not call the function
>> under the lock in the first place.
>>
>> Generated by: scripts/coccinelle/locks/call_kern.cocci
>>
>> Fixes: 48197bc564c7 ("drm: add syncobj timeline support v9")
>> CC: Chunming Zhou <david1.zhou@amd.com>
>> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
>> ---
>>
>> tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip
>> head: 8d7ffd2298c607c3e1a16f94d51450d7940fd6a7
>> commit: 48197bc564c7a1888c86024a1ba4f956e0ec2300 [1968/2033] drm: add
>> syncobj timeline support v9
>> :::::: branch date: 4 hours ago
>> :::::: commit date: 5 days ago
>>
>> Please take the patch only if it's a positive warning. Thanks!
>>
>> drm_syncobj.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/drivers/gpu/drm/drm_syncobj.c
>> +++ b/drivers/gpu/drm/drm_syncobj.c
>> @@ -199,7 +199,7 @@ static struct dma_fence
>> (point <= syncobj->timeline)) {
>> struct drm_syncobj_stub_fence *fence =
>> kzalloc(sizeof(struct drm_syncobj_stub_fence),
>> - GFP_KERNEL);
>> + GFP_ATOMIC);
>>
>> if (!fence)
>> return NULL;
next prev parent reply other threads:[~2018-10-25 6:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 18:57 [PATCH] drm: fix call_kern.cocci warnings (fwd) Julia Lawall
2018-10-25 1:28 ` Zhou, David(ChunMing)
2018-10-25 6:53 ` Christian König [this message]
2018-10-25 7:51 ` Maarten Lankhorst
2018-10-25 7:57 ` Koenig, Christian
2018-10-25 8:31 ` zhoucm1
2018-10-25 7:50 ` Maarten Lankhorst
2018-10-25 7:55 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=823eb7cc-ba7e-b816-1821-c73dfd4c70bf@googlemail.com \
--to=easy2remember.chk@googlemail.com \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=julia.lawall@lip6.fr \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).