linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@oracle.com>,
	David Lechner <david@lechnology.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Santosh Shilimkar <ssantosh@kernel.org>
Cc: Franklin S Cooper Jr <fcooper@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Kevin Hilman <khilman@kernel.org>,
	Axel Haslam <ahaslam@baylibre.com>,
	Alexandre Bailon <abailon@baylibre.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Jiri Slaby <jslaby@suse.com>, <linux-serial@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/4] ARM: dts: keystone: Add "ti,da830-uart" compatible string
Date: Thu, 5 Jan 2017 14:34:10 +0530	[thread overview]
Message-ID: <824238e0-b710-7146-b67b-b2135c2a8bd2@ti.com> (raw)
In-Reply-To: <93c4aed0-6faa-2c27-7931-454fc1f48e79@oracle.com>

Hi Santosh,

On Thursday 05 January 2017 03:30 AM, Santosh Shilimkar wrote:
> On 1/4/2017 12:30 PM, David Lechner wrote:
>> The TI Keystone SoCs have extra UART registers beyond the standard 8250
>> registers, so we need a new compatible string to indicate this. Also, at
>> least one of these registers uses the full 32 bits, so we need to specify
>> reg-io-width in addition to reg-shift.
>>
>> "ns16550a" is left in the compatible specification since it does work as
>> long as the bootloader configures the SoC UART power management
>> registers.
>>
> NAK!!
> We can't break the booting boards with existing boot loaders.

Sorry, but it not clear to me how this breaks booting with older
bootloaders? If older DTB is ROM'ed, it will continue to work because of
match with ns16550a.

I just verified boot on K2E with these patches applied and using 2016.05
based U-Boot from a TI release.

http://pastebin.ubuntu.com/23744719/

> I suggest you to first get the driver updated to take care of
> the UART PM register and then enable the support for it.

Isn't that what patch 2/4 is doing?

Thanks,
Sekhar

  reply	other threads:[~2017-01-05  9:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-04 20:30 [PATCH v2 0/4] TI DA8xx/OMAPL13x/AM17xx/AM18xx/C66x UART David Lechner
2017-01-04 20:30 ` [PATCH v2 1/4] doc: DT: Add ti,da830-uart to serial/8250 bindings David Lechner
2017-01-04 20:30 ` [PATCH v2 2/4] serial: 8250: Add new port type for TI DA8xx/OMAPL13x/AM17xx/AM18xx/C66x David Lechner
2017-01-05  8:21   ` Sekhar Nori
2017-01-04 20:30 ` [PATCH v2 3/4] ARM: da850: Add ti,da830-uart compatible for serial ports David Lechner
2017-01-04 20:30 ` [PATCH v2 4/4] ARM: dts: keystone: Add "ti,da830-uart" compatible string David Lechner
2017-01-04 22:00   ` Santosh Shilimkar
2017-01-05  9:04     ` Sekhar Nori [this message]
2017-01-05 17:10       ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=824238e0-b710-7146-b67b-b2135c2a8bd2@ti.com \
    --to=nsekhar@ti.com \
    --cc=abailon@baylibre.com \
    --cc=ahaslam@baylibre.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=david@lechnology.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fcooper@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=santosh.shilimkar@oracle.com \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).