From: Kishon Vijay Abraham I <kishon@ti.com>
To: Caesar Wang <wxt@rock-chips.com>,
Douglas Anderson <dianders@chromium.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: <hl@rock-chips.com>, <linux-rockchip@lists.infradead.org>,
<dbasehore@chromium.org>, <mka@chromium.org>,
<ryandcase@chromium.org>, <groeck@chromium.org>,
Elaine Zhang <zhangqing@rock-chips.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
"nickey.yang (nickey.yang@rock-chips.com)"
<nickey.yang@rock-chips.com>, wzz <wzz@rock-chips.com>,
Huang Jiachai <hjc@rock-chips.com>
Subject: Re: [PATCH] phy: rockchip-dp: Avoid power leak by leaving the PHY power on
Date: Mon, 3 Jun 2019 16:50:33 +0530 [thread overview]
Message-ID: <82480aa5-ab2e-11c5-8dd5-c395f72fc6e7@ti.com> (raw)
In-Reply-To: <79ca5499-6b7d-fe55-2030-283f5cfb1d27@rock-chips.com>
Hi,
On 20/05/19 1:34 PM, Caesar Wang wrote:
> Hi Doug,
>
> For now, nobody of rockchip is responsible for this driver.
> Cc: Nickey, Zain, Hjc
>
>
> On 5/8/19 7:48 AM, Douglas Anderson wrote:
>> While testing a newer kernel on rk3288-based Chromebooks I found that
>> the power draw in suspend was higher on newer kernels compared to the
>> downstream Chrome OS 3.14 kernel. Specifically the power of an
>> rk3288-veyron-jerry board that I tested (as measured by the smart
>> battery) was ~16 mA on Chrome OS 3.14 and ~21 mA on a newer kernel.
>>
>> I tracked the regression down to the fact that the "DP PHY" driver
>> didn't exist in our downstream 3.14. We relied on the eDP driver to
>> turn on the clock and relied on the fact that the power for the PHY
>> was default turned on.
>>
>> Specifically the thing that caused the power regression was turning
>> the eDP PHY _off_. Presumably there is some sort of power leak in the
>> system and when we turn the PHY off something is leaching power from
>> something else and causing excessive power draw.
>>
>> Doing a search through device trees shows that this PHY is only ever
>> used on rk3288. Presumably this power leak is present on all
>> rk3288-SoCs running upstream Linux so let's just whack the driver to
>> make sure we never turn off power. We'll still leave the parts that
>> turn _on_ the power and grab the clock, though.
>>
>> NOTES:
>> A) If someone can identify what this power leak is and fix it in some
>> other way we can revert this patch.
>> B) If someone can show that their particular board doesn't have this
>> power leak (maybe they have rails hooked up differently?) we can
>> perhaps add a device tree property indicating that for some boards
>> it's OK to turn this rail off. I don't want to add this property
>> until I know of a board that needs it.
>>
>> Fixes: fd968973de95 ("phy: Add driver for rockchip Display Port PHY")
>> Signed-off-by: Douglas Anderson <dianders@chromium.org>
>
>
> Reviewed-by: Caesar Wang <wxt@rock-chips.com>
>
>> ---
>> As far as I know Yakir (the original author) is no longer at Rockchip.
>> I've added a few other Rockchip people and hopefully one of them can
>> help direct even if they're not directly responsible.
>>
>> drivers/phy/rockchip/phy-rockchip-dp.c | 11 +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/phy/rockchip/phy-rockchip-dp.c
>> b/drivers/phy/rockchip/phy-rockchip-dp.c
>> index 8b267a746576..10bbcd69d6f5 100644
>> --- a/drivers/phy/rockchip/phy-rockchip-dp.c
>> +++ b/drivers/phy/rockchip/phy-rockchip-dp.c
>> @@ -35,7 +35,7 @@ struct rockchip_dp_phy {
>> static int rockchip_set_phy_state(struct phy *phy, bool enable)
>> {
>> struct rockchip_dp_phy *dp = phy_get_drvdata(phy);
>> - int ret;
>> + int ret = 0;
>> if (enable) {
>> ret = regmap_write(dp->grf, GRF_SOC_CON12,
>> @@ -50,9 +50,12 @@ static int rockchip_set_phy_state(struct phy *phy, bool
>> enable)
>> } else {
>> clk_disable_unprepare(dp->phy_24m);
>> - ret = regmap_write(dp->grf, GRF_SOC_CON12,
>> - GRF_EDP_PHY_SIDDQ_HIWORD_MASK |
>> - GRF_EDP_PHY_SIDDQ_OFF);
>> + /*
>> + * Intentionally don't turn SIDDQ off when disabling
>> + * the PHY. There is a power leak on rk3288 and
>> + * suspend power _increases_ by 5 mA if you turn this
>> + * off.
>> + */
Can someone in Rockchip try to find the root-cause of the issue? Keeping the
PHY off shouldn't increase power draw.
Thanks
Kishon
next prev parent reply other threads:[~2019-06-03 11:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 23:48 [PATCH] phy: rockchip-dp: Avoid power leak by leaving the PHY power on Douglas Anderson
2019-05-17 23:57 ` Doug Anderson
2019-05-18 7:51 ` Heiko Stuebner
2019-05-18 13:42 ` Doug Anderson
2019-05-20 8:04 ` Caesar Wang
2019-06-03 11:20 ` Kishon Vijay Abraham I [this message]
2019-06-03 15:22 ` Doug Anderson
2019-06-03 15:23 ` Doug Anderson
2019-07-22 21:52 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82480aa5-ab2e-11c5-8dd5-c395f72fc6e7@ti.com \
--to=kishon@ti.com \
--cc=dbasehore@chromium.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=hl@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mka@chromium.org \
--cc=nickey.yang@rock-chips.com \
--cc=ryandcase@chromium.org \
--cc=wxt@rock-chips.com \
--cc=wzz@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).