From: Chanwoo Choi <cw00.choi@samsung.com>
To: Colin King <colin.king@canonical.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: sm5502: remove redundant assignment to variable cable_type
Date: Thu, 31 Oct 2019 13:48:10 +0900 [thread overview]
Message-ID: <824f99c7-8de2-2b32-4d12-8a45e73b2349@samsung.com> (raw)
In-Reply-To: <20191025131227.24894-1-colin.king@canonical.com>
On 19. 10. 25. 오후 10:12, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable cable_type is being initialized with a value that
> is never read and is being re-assigned a little later on. The
> assignment is redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/extcon/extcon-sm5502.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c
> index b3d93baf4fc5..bcf65aaca5d2 100644
> --- a/drivers/extcon/extcon-sm5502.c
> +++ b/drivers/extcon/extcon-sm5502.c
> @@ -276,7 +276,7 @@ static int sm5502_muic_set_path(struct sm5502_muic_info *info,
> /* Return cable type of attached or detached accessories */
> static unsigned int sm5502_muic_get_cable_type(struct sm5502_muic_info *info)
> {
> - unsigned int cable_type = -1, adc, dev_type1;
> + unsigned int cable_type, adc, dev_type1;
> int ret;
>
> /* Read ADC value according to external cable or button */
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
prev parent reply other threads:[~2019-10-31 4:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191025131232epcas4p262cce6ea441f3f1b9251810ad9427732@epcas4p2.samsung.com>
2019-10-25 13:12 ` [PATCH] extcon: sm5502: remove redundant assignment to variable cable_type Colin King
2019-10-31 4:48 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=824f99c7-8de2-2b32-4d12-8a45e73b2349@samsung.com \
--to=cw00.choi@samsung.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).