linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Mark Brown <broonie@kernel.org>, Theodore Ts'o <tytso@mit.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] random: Document add_hwgenerator_randomness() with other input functions
Date: Fri, 24 Jan 2020 12:23:57 -0800	[thread overview]
Message-ID: <825bf310-8ae6-ba62-1b70-709c738a7aa5@infradead.org> (raw)
In-Reply-To: <20200124134106.8472-1-broonie@kernel.org>

On 1/24/20 5:41 AM, Mark Brown wrote:
> The section at the top of random.c which documents the input functions
> available does not document add_hwgenerator_randomness() which might lead
> a reader to overlook it. Add a brief note about it.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  drivers/char/random.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index c7f9584de2c8..16070c36add3 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -228,6 +228,14 @@
>   * particular randomness source.  They do this by keeping track of the
>   * first and second order deltas of the event timings.
>   *
> + * There is also an interface for true hardware RNGs:
> + *
> + *	void add_hwgenerator_randomness(const char *buffer, size_t count,
> + *				size_t entropy);
> + *
> + * This will credit entropy as specified by the caller, if the entropy

Not a comma there. Either a ';' or "caller. If ..."

> + * pool is full it will block until more entropy is needed.
> + *
>   * Ensuring unpredictability at system startup
>   * ============================================
>   *
> 

thanks.
-- 
~Randy


  reply	other threads:[~2020-01-24 20:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-24 13:41 [PATCH] random: Document add_hwgenerator_randomness() with other input functions Mark Brown
2020-01-24 20:23 ` Randy Dunlap [this message]
2020-04-24 12:39 Mark Brown
2020-04-24 16:03 ` Randy Dunlap
2020-07-01 17:15 Mark Brown
2021-01-13 17:10 Mark Brown
2021-05-11 17:29 Mark Brown
2021-07-12 12:07 Mark Brown
2021-09-21 21:39 Mark Brown
2021-10-15 13:34 Mark Brown
2021-11-15 17:42 Mark Brown
2021-12-01 17:44 Mark Brown
2021-12-02  4:48 ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=825bf310-8ae6-ba62-1b70-709c738a7aa5@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).