From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A70DC4332F for ; Wed, 6 Oct 2021 12:51:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 011A261039 for ; Wed, 6 Oct 2021 12:51:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238624AbhJFMw6 (ORCPT ); Wed, 6 Oct 2021 08:52:58 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:49740 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238610AbhJFMwz (ORCPT ); Wed, 6 Oct 2021 08:52:55 -0400 Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id D10F63FFE8 for ; Wed, 6 Oct 2021 12:51:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1633524661; bh=PKetBUdtpr3Hr2NvlRZBfrIHbbw2Nu4lIQoW/4WvUOo=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=qIkX5gx6oDxcWl2rcnIUJuSMelK04mYJNfaUqN3Qkbz4TmG0JwWo4DcceB+kqj3u6 b+nVoBsiufKSkFoqS7pmGMhXILYLVlfao4jwzTX8uOfy3Q7G5x0Spygj53afDNcbP1 75CIyexU42MG1TSF3L+qQTRXQb2bGtTBu9gwA5nlDbFEj9d39hhfSzAJk+lryAW+oW k4D0zSj7NfZTx1AQZngeqtHwpcnSMoUsF31wN9U+UPHGw0KnKv2SExfbxBlwPBjrfU RqKSNclztvxhiimv5g6eA7W+mEs4B3nikuTIShyK2XcdUqG8HUrJrWAOXuLvPNJhjF ksxdyZKTyoEPQ== Received: by mail-lf1-f69.google.com with SMTP id v2-20020ac25582000000b003fd1c161a31so1873242lfg.15 for ; Wed, 06 Oct 2021 05:51:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PKetBUdtpr3Hr2NvlRZBfrIHbbw2Nu4lIQoW/4WvUOo=; b=u1xbOedIgK8fqlthHkN6BsIvn0UIuYdqErzkfzRlCqWRMnMvlDblDy9IRTZhIPwX/E kywQV4t6NURkeTGozyOtVA3Cv+7wzy/q6L9lU7gDNddrfqPYOMnXBRp0csOlEH8UAtkX 9ESmZGOJbX8tdJbW3OjVGFoQc/LYW/WTKsgPNsLgOtFq9pTlm3KZBVAbWy6V7+qqDDLH V/5DLMxnw1CjfBfrMhKpDikBWUtsBaFHTSAOJcy4Xx42cePYIij4qjAEvXnHFfIXZBIc DElVg5iQN81f61xzaaGuiRFVkkXgmRUUUf9+x7RXuYtbVes5Lqqc+PGa2xzv+IvWq5pJ N1eA== X-Gm-Message-State: AOAM531q9pasGkgMtxphZ7r32/l9rgNFcUTR+XgqBMV+i2/MlgGeg+11 acOYSqppktWcl0fbmeD1t5G8oayU1PJOhPyiVFP3woSJtnPxFPxMsiUuGXh/BaqAys6p/19XKWE zUDRehP4eHfOGivFCx57fcgUhoPv5KEBA6OhCiCPCPA== X-Received: by 2002:ac2:50d3:: with SMTP id h19mr9138096lfm.63.1633524661202; Wed, 06 Oct 2021 05:51:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYQXpRfbdij+G/IdEjueEdrmnNAVv9YGwPu64Trw30ig3vpNtjLztb74XfXOnojeuZlsz62w== X-Received: by 2002:ac2:50d3:: with SMTP id h19mr9138078lfm.63.1633524661042; Wed, 06 Oct 2021 05:51:01 -0700 (PDT) Received: from [192.168.0.20] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id q1sm2261481lfg.18.2021.10.06.05.50.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Oct 2021 05:51:00 -0700 (PDT) Subject: Re: [PATCH 6/6] clk: samsung: Introduce Exynos850 clock driver To: Sam Protsenko Cc: Sylwester Nawrocki , =?UTF-8?Q?Pawe=c5=82_Chmiel?= , Chanwoo Choi , Tomasz Figa , Rob Herring , Stephen Boyd , Michael Turquette , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree , linux-arm Mailing List , linux-clk , Linux Kernel Mailing List , Linux Samsung SOC References: <20210914155607.14122-1-semen.protsenko@linaro.org> <20210914155607.14122-7-semen.protsenko@linaro.org> <3da75dbe-2f98-39db-c455-46adead7097b@canonical.com> From: Krzysztof Kozlowski Message-ID: <826fa28d-05a9-4a1c-a69b-70fc50e26e24@canonical.com> Date: Wed, 6 Oct 2021 14:50:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/2021 13:29, Sam Protsenko wrote: > On Wed, 15 Sept 2021 at 11:59, Krzysztof Kozlowski > wrote: >> > >>> + val = ioread32(reg); >>> + val |= GATE_MANUAL; >>> + val &= ~GATE_ENABLE_HWACG; >>> + iowrite32(val, reg); >> >> All other drivers use readl/writel, so how about keeping it consistent? >> > > Ok. Though io* variants looks better to me (API names consistent with > ioremap/iounmap) :) The io* variants are for PCI I/O and I/O port. Since we know this is MMIO, all drivers use regular readX/writeX, so let's keep it the same. Best regards, Krzysztof