From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBA7BC433E3 for ; Tue, 30 Mar 2021 14:23:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE948619CE for ; Tue, 30 Mar 2021 14:23:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232217AbhC3OXT (ORCPT ); Tue, 30 Mar 2021 10:23:19 -0400 Received: from mga09.intel.com ([134.134.136.24]:15630 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232141AbhC3OXE (ORCPT ); Tue, 30 Mar 2021 10:23:04 -0400 IronPort-SDR: nR9NUb2xROaGigpRtLMVCWocP4gFQkAs+ZJa/oOMWceOvnUrLLST15azimzX1uJsSGg8+b8l8k g3lOOSZei8rw== X-IronPort-AV: E=McAfee;i="6000,8403,9939"; a="191874655" X-IronPort-AV: E=Sophos;i="5.81,291,1610438400"; d="scan'208";a="191874655" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 07:23:00 -0700 IronPort-SDR: ghwn0ifiJw8J7fxvJoWtadsdpQs8QxU/11b4VnX/XZukEvV1bDWcHn9gPakWimqSBwy6MTEMIl 2J8X0rYuD8Cw== X-IronPort-AV: E=Sophos;i="5.81,291,1610438400"; d="scan'208";a="393626944" Received: from feifeich-mobl1.amr.corp.intel.com (HELO [10.212.41.240]) ([10.212.41.240]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 07:22:58 -0700 Subject: Re: [PATCH] ASoC: amd: Add support for ALC1015P codec in acp3x machine driver To: Vijendar Mukunda , broonie@kernel.org, alsa-devel@alsa-project.org Cc: shumingf@realtek.com, flove@realtek.com, kent_chen@realtek.com, jack.yu@realtek.com, Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Ravulapati Vishnu vardhan rao , Arnd Bergmann , Akshu Agrawal , Kuninori Morimoto , Tzung-Bi Shih , open list References: <1617095628-8324-1-git-send-email-Vijendar.Mukunda@amd.com> From: Pierre-Louis Bossart Message-ID: <82817878-a30d-2b0c-07f8-48bcca3ebc80@linux.intel.com> Date: Tue, 30 Mar 2021 09:22:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1617095628-8324-1-git-send-email-Vijendar.Mukunda@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static const struct acpi_device_id acp3x_audio_acpi_match[] = { > { "AMDI5682", (unsigned long)&acp3x_5682}, > { "AMDI1015", (unsigned long)&acp3x_1015}, > + { "AMDP1015", (unsigned long)&acp3x_1015p}, This isn't a valid ACPI ID. AMDP does not exist in https://uefi.org/acpi_id_list There was a similar issue with Intel platforms using this part, we had to use a different HID.