From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CC67C433F5 for ; Thu, 26 May 2022 10:40:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347066AbiEZKkG (ORCPT ); Thu, 26 May 2022 06:40:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344583AbiEZKj7 (ORCPT ); Thu, 26 May 2022 06:39:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 10CDCCC16D for ; Thu, 26 May 2022 03:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653561597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+r8IRfW0aiu0JceyLx2VcCldtR76oQiy6OB80vh4MBU=; b=UuKabnlS2KsPcL66OyNh962UV2itohE+kT91gcanIVqYt9MsDU+IGcW6zJLXwRWzzZVEgD 4XPvsVjVxQTxHAd4PgGCsLBDj2CP7PE5Sq45ek7m4wHsafvOPth1QRbMGBiFeoRL6HyQF3 s8+rTWCr1TP7enVhkNwjBO3N1CGelKg= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-557--pr031zbNSqrd5DnEH0vHg-1; Thu, 26 May 2022 06:39:55 -0400 X-MC-Unique: -pr031zbNSqrd5DnEH0vHg-1 Received: by mail-ed1-f69.google.com with SMTP id i8-20020a50fd08000000b0042baef934f5so811137eds.16 for ; Thu, 26 May 2022 03:39:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+r8IRfW0aiu0JceyLx2VcCldtR76oQiy6OB80vh4MBU=; b=Yk5835SuxIz3ztzDpuj6dvIh2NGzLn8/WWhNMQ56rgLP9di483ICznuEsovm4IxR6C 79LBsR+BRtJxmtVLs38ktc6KuC/H+byy+at6HsIJQ1zxy36Bk5KLlLhVq05Gv79tChcM LaZRJUVc72W29RS7JldSdd885ddz8NFl2PF8mcriVhTzQ1ZiOAFIyVdvnKGFGiRXWmhs /wTkXk5zVPqWoY48Pm+cmttONB+fAQTB8R8yOBHoWnNDv0sQHAXwLJRrwXgqeLdhVAuY I5pTZDJy+z0zImTISJnD4mjRcd+zaCyiGlj2IjeVErek1jTUGTO7G1Rk9qsg9T0i8n13 K6Sg== X-Gm-Message-State: AOAM531FS3i2RI5AS7ch7W673j4GMY6tkrO+YdIetn9V1L4YLz2a7tKS i4IfK/1VTEOHZWZWY8Y/Yl6UwoZH0/fKVmp37anXsQLlrXhn8DPmLLz4EGwocXRAK0FuJSqon1b /JYM9AnICgDIRfNbouK+SqT53 X-Received: by 2002:a17:906:f17:b0:6fe:94f6:cb8a with SMTP id z23-20020a1709060f1700b006fe94f6cb8amr31800178eji.456.1653561594741; Thu, 26 May 2022 03:39:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUSYGuJiw8tlBQEs9M1/lLmuEsmHtBEs/SiLz744J3SQye6+zzJi4pp7socx6vuf4BRlOQcA== X-Received: by 2002:a17:906:f17:b0:6fe:94f6:cb8a with SMTP id z23-20020a1709060f1700b006fe94f6cb8amr31800168eji.456.1653561594551; Thu, 26 May 2022 03:39:54 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id c10-20020a05640227ca00b0042ab9da73e6sm633908ede.94.2022.05.26.03.39.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 May 2022 03:39:53 -0700 (PDT) Message-ID: <8288b833-68f0-9fd2-d4d4-21cc9aff5ec2@redhat.com> Date: Thu, 26 May 2022 12:39:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/2] KVM: VMX: Add knob to allow rejecting kvm_intel on inconsistent VMCS config Content-Language: en-US To: Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Chenyi Qiang , Lei Wang References: <20220525210447.2758436-1-seanjc@google.com> <20220525210447.2758436-3-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20220525210447.2758436-3-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/25/22 23:04, Sean Christopherson wrote: > Add an off-by-default module param, reject_inconsistent_vmcs_config, to > allow rejecting the load of kvm_intel if an inconsistent VMCS config is > detected. Continuing on with an inconsistent, degraded config is > undesirable when the CPU is expected to support a given set of features, > e.g. can result in a misconfigured VM if userspace doesn't cross-check > KVM_GET_SUPPORTED_CPUID, and/or can result in poor performance due to > lack of fast MSR switching. > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/vmx/vmx.c | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) Yeah let's do this by default. Paolo