From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbdEPU5M (ORCPT ); Tue, 16 May 2017 16:57:12 -0400 Received: from mail.anw.at ([195.234.101.228]:40038 "EHLO mail.anw.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbdEPU5J (ORCPT ); Tue, 16 May 2017 16:57:09 -0400 X-Greylist: delayed 549 seconds by postgrey-1.27 at vger.kernel.org; Tue, 16 May 2017 16:57:08 EDT Subject: Re: [PATCH] staging: media: cxd2099: Fix checkpatch issues To: eddi1983 , mchehab@kernel.org References: <20170516200740.27692-1-eddi1983@gmx.net> Cc: gregkh@linuxfoundation.org, diaconitatamara@gmail.com, daniel.baluta@gmail.com, eraretuya@gmail.com, elise.lennion@gmail.com, linux-media@vger.kernel.org, 0devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: "Jasmin J." Message-ID: <82946e90-46a5-de5a-40db-adeaa4839976@anw.at> Date: Tue, 16 May 2017 22:47:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170516200740.27692-1-eddi1983@gmx.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: checked in 0.022sec at mail.anw.at ([195.234.102.72]) by smf-clamd v1.2.1 - http://smfs.sf.net/ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Christoph! The current cxd2099 driver is an old version. DD provides a newer variant. Please see my patch series http://www.mail-archive.com/linux-media@vger.kernel.org/msg112410.html Especially this patch http://www.mail-archive.com/linux-media@vger.kernel.org/msg112409.html where I remove this useless printing already. I kept the "slot_shutdown" print in my series, because it is useful and called only if someone removes the CAM, but I removed all the other useless ones. So I can agree with your first hunk. It would be better to wait with this change after my series is approved! BR, Jasmin