Hi Tom, Thanks for the patch! Patch is, Acked-by: Samuel Iglesias Gonsalvez Greg, Would you mind picking this patch through your char-misc tree? Thanks! Sam On Mon, 2020-10-19 at 12:32 -0700, trix@redhat.com wrote: > From: Tom Rix > > A break is not needed if it is preceded by a return > > Signed-off-by: Tom Rix > --- > drivers/ipack/devices/ipoctal.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ipack/devices/ipoctal.c > b/drivers/ipack/devices/ipoctal.c > index d480a514c983..3940714e4397 100644 > --- a/drivers/ipack/devices/ipoctal.c > +++ b/drivers/ipack/devices/ipoctal.c > @@ -544,7 +544,6 @@ static void ipoctal_set_termios(struct tty_struct > *tty, > break; > default: > return; > - break; > } > > baud = tty_get_baud_rate(tty);