From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
<linux-snps-arc@lists.infradead.org>
Cc: <linux-kernel@vger.kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] arc: Add "include chroot" for DT bindings
Date: Tue, 30 May 2017 09:30:43 -0700 [thread overview]
Message-ID: <82af576a-939b-f8cc-5c52-3b4ffb389dcb@synopsys.com> (raw)
In-Reply-To: <1496150575-9273-1-git-send-email-abrodkin@synopsys.com>
On 05/30/2017 06:22 AM, Alexey Brodkin wrote:
> Basically this extends
> c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
> ARC where we extensively use Device Tree and there're good reasons
> to use DT bindings, especially if those are required.
>
> Otherwise on attempt to compile .dts with something like:
> -------------------->8---------------------
> #include <dt-bindings/net/ti-dp83867.h>
> -------------------->8---------------------
>
> we inevitably see this compilation failure:
> -------------------->8---------------------
> arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
> #include <dt-bindings/net/ti-dp83867.h>
> ^
> compilation terminated.
> -------------------->8---------------------
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
> arch/arc/boot/dts/include/dt-bindings | 1 +
> 1 file changed, 1 insertion(+)
> create mode 120000 arch/arc/boot/dts/include/dt-bindings
>
> diff --git a/arch/arc/boot/dts/include/dt-bindings b/arch/arc/boot/dts/include/dt-bindings
> new file mode 120000
> index 000000000000..08c00e4972fa
> --- /dev/null
> +++ b/arch/arc/boot/dts/include/dt-bindings
> @@ -0,0 +1 @@
> +../../../../../include/dt-bindings
> \ No newline at end of file
I'm OK with adding this to ARC, but won't it be nicer to have a generic include
helper instead to avoid boilerplate addition in multiple places ?
-Vineet
next prev parent reply other threads:[~2017-05-30 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 13:22 [PATCH] arc: Add "include chroot" for DT bindings Alexey Brodkin
2017-05-30 16:30 ` Vineet Gupta [this message]
2017-05-30 16:56 ` Rob Herring
2017-05-30 17:04 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82af576a-939b-f8cc-5c52-3b4ffb389dcb@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).