From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753632AbcKGQ7k (ORCPT ); Mon, 7 Nov 2016 11:59:40 -0500 Received: from mail-db5eur01on0109.outbound.protection.outlook.com ([104.47.2.109]:27776 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752015AbcKGQ7i (ORCPT ); Mon, 7 Nov 2016 11:59:38 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH] coredump: fix unfreezable coredumping task To: Alexander Viro , Tejun Heo , "Rafael J. Wysocki" , Pavel Machek , "Oleg Nesterov" References: <1475225434-3753-1-git-send-email-aryabinin@virtuozzo.com> CC: , , , , Linus Torvalds , Andrew Morton From: Andrey Ryabinin Message-ID: <82d0dc53-6a4d-52f2-56e7-030ec9f1e07d@virtuozzo.com> Date: Mon, 7 Nov 2016 19:27:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1475225434-3753-1-git-send-email-aryabinin@virtuozzo.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM5PR0101CA0015.eurprd01.prod.exchangelabs.com (10.169.240.25) To AM5PR0801MB2049.eurprd08.prod.outlook.com (10.168.158.139) X-MS-Office365-Filtering-Correlation-Id: 1b68e0da-3bf8-4627-c7fb-08d4072ae0e9 X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB2049;2:qj5G7TOjVitURCnr/kw5tSHuIpqnvjTUm4VvlRBRVeEY/BwXhqCYTtkzScSed+fizgGVl+1z50QNNoRFIpUzrJWcagrkt5pyLIqRAkdZTMIhzw9K1ilDqUH/AnhjsR7/4O2iFJXdvG3LPVExapNTgb4sKirYOfAXQ5IYt/hZy58A81b9WAtpsEKq1gMej72yCSCxdpwdmGhvqkqg6lYOGg==;3:5mFqziH8Jqde9gODVmcQGf4BW+m8lhGnjezyQFxVZYPmoQRIliXnWYjEfNacmAGYGC0/KvkWL771LgTZbN3qrC0XnVs2Drq1Z0qC2hLSjhoCjOUXKxMEnMmtuUUbbLDe8hg/kNvosb4ML9cszaFY3Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB2049; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB2049;25:/VEPLM3y7hbTKwaQOmTYacj7Zkf46wGR4Vq9qjMpuy2a5YGoh/pbPWtXG5URZdI93FO8JYYTuGsC0cpmN3g1u1rWDkg+D05hHiI+VdS5VY5D4OH2udFEk7GN+CyAtlrN/D4wBICpUUdlOVBSGmiHE1qzqsaAnlWHNZ3vc8KLGXMkFmgzl/QBAhVdwk4v9E7S1S5FAi2xmVCPX/dZRfWGTVg4PaXvRm1+nLtt+2yfNt9fN00h79v4PeGP7WfK4Hnby6rLgxmR94rfHOVQnt7eAN+BtTZOjgIDs3TYmByk2Esf/vlufTFTQenQ0fyv9Ja6YSmzHi+7ACLg1oUpTkyiq7L8Iu0gIljiVElamIvaQCH9pirw2E/FdEKkmEyBkFmNE0dLA5B5ksLnh4kPk8f5R6lrxIkm0t1cfWoOO6IVYUjibZXVCe1qlrIhPFP+0QEabej1jlUxI9aDNZxMCTE1NaUitdvUQqdoJSD523GmqvP/Yy+4QPjHOlc3lltzzSZ3KRZpW6ZHzswv+nR5ktpkXhAGRDgiKky6otZAa21Us+QrBhVKn5bDGoVPzE74zGpZqg352kV3LO6OhTFJtBhjVphFw9En+wgwtLUlHdegl3pvnoqOq3RgFHWzKM0gNx7iqQAHj7c0vYN0KD6evhxecVO6Y9Rav5Cz+Oqn6rCt9Pt1+gJHOUfVbhUMrfZGoWaLljuLwgcfXEWTSzCoZXlFyK1u8CtaCIeZihOv5mVXOgv9jk80zseNfn7/gNgKCzWq X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB2049;31:SO1K7nVwqgjofvbWyyeo8boYnELusjDcrmXn/35heLpK1eXvOb1cqxZmxwSR7tE4xPgxxjD5Y4676GNb+3MRIBPeyNMbt0uvROoD+uTIarW4FhpfePcpfPAV5AG82GGcw+CMpdIFWUs5sU//2/Em+Muy82E1b0QvmubzvwNF2a4OLm8kRuAUXw1Nbg5Yapa8Uonq3aYMGl2CKMVm0bDM3hj1fhpwOnh/K9RvO47mM9wMy9uusyrM4KGqP8qKE5G9;20:PJK3paaYTZBmBHxsyEIG2P5ISGDPYorM+mT4i92OIjbpvG+uGW2DwmXjn7GbyAWQJ6ApVyYJdpVnPDCSyqaRpJFtvDPjcuJYSFWytw/1kTCYG5NcUT9w5SzW3sj9uhMsoxw5KpZyQ98PPEsszo3b+Udo2Ly7tJ9fwXh4HiU7SQW3NgD8gdaVSSeMVyFSFOtsh39sd/T2Nb4PF28jmhr1HLb6K+SEECjpNpuyMyBtuRG+5QzWg/x/PhpXvPPwMzYc X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6043046)(6042046);SRVR:AM5PR0801MB2049;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB2049; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB2049;4:3T5Y6/iGAx+jOVzBLoKBjvzoqsYu+wTMiqD0fgeAabyEQKEw5kbREQfHwxWjsAVTql+4Vpv//FHNiEJtfYJTwgIrMDfo2smH6pM8CN1DFnsjGK73mIQ9/MqLfFpWgaL1b1b0p/pstknVu74l9s8CsyjT+xgEWxiR9Kn66HJhnbOsn621cdHRALUnOrwjXWcGwl7pvK0Qn2fG9ZOz31IGvX+G9sEQnp6Y4fSA+ydDllQZKENLCkCs7BB5RZc0pH9ihAMAUzOR2aCy7L+u28DnOaGiXfm8KsWTfPvz1XtVZtDYxPFieirivO7yGyHRiJ4fd1N3jMEJa2FhSyLjnHuWJV/YILHnUUfwf/tvr4rCHGOg8fN/e4IaCSO49/WGRChNGkSqZ9iw68E7lqLJtxg5cU9JAlUzrWluhQjFurel09vj8NhZk0Pq8pyK7g25zQi+SqP5839bLgZlhpwlYXVitH6ta8dIZ4bETuSokfN9VbY= X-Forefront-PRVS: 0119DC3B5E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(189002)(377454003)(24454002)(199003)(5001770100001)(105586002)(86362001)(76176999)(92566002)(4001350100001)(586003)(83506001)(6116002)(230700001)(8676002)(7416002)(2950100002)(50986999)(54356999)(5660300001)(6666003)(23746002)(4326007)(7736002)(2906002)(36756003)(3846002)(7846002)(65826007)(81166006)(81156014)(101416001)(77096005)(189998001)(64126003)(31696002)(106356001)(66066001)(65956001)(305945005)(19580395003)(97736004)(50466002)(47776003)(19580405001)(42186005)(68736007)(33646002)(31686004)(65806001);DIR:OUT;SFP:1102;SCL:1;SRVR:AM5PR0801MB2049;H:[10.30.19.223];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM5PR0801MB2049;23:cHYxRNdcO06SLj37IQMaYvvBCjHyob1Tzxh?= =?Windows-1252?Q?GLY0tocgnWFjGTsWgTWyT6EtTp+civHfyIIPRamYI5uDTGW/v2WqA1DL?= =?Windows-1252?Q?TkNywNxAZcRVZaKtiCF+PjwLmzEBJE9Czb6X6F8i+4SQJ4J27kHMWqLa?= =?Windows-1252?Q?lYy8bTABosfdu4X0L/tTx5dFoFCbkIIvO2NcEPrzca7CxquuffiGj1B4?= =?Windows-1252?Q?9ABCKPR2ILgXyCr3tCGqzq/AiXIb6xHjDO7zlm5Rym7RiMX8SWa3gEnI?= =?Windows-1252?Q?2EreKUGc6uYqSrz9hdtN65cedOZkfDMMADhonIorfWx5p1lO4dFidRfG?= =?Windows-1252?Q?8lAKXnlcAqF3bnHI2bUPTJuU4n3EVv8dVd+awvIZJImDPvF8Q1oM/d0w?= =?Windows-1252?Q?4urSmpc4bADodYBXLIZFCV6gIXfj5BYGiraoyyp1HsThCIK5P4My7G4+?= =?Windows-1252?Q?qvWs9HIWhshBM75saFn2THdtszlJyCqcOtcQRWyEXGtEwk9226nBw2aQ?= =?Windows-1252?Q?/Gk4+ytbC9wC2bdUH2agt5WOJYCVJ7X9UVjab/rsd1CQF5yqdAl9JJN6?= =?Windows-1252?Q?2uPpmN3XYbJl2zvZoj+7OxW7ejGGoPrR+5mWs1S0nkCN0o4w88ctLr/M?= =?Windows-1252?Q?XcjfQ36dpSvrn6au7QG7drE6h2vBSCxWRwZCn9n39hX/eau+aGFeqlcU?= =?Windows-1252?Q?NOVm3T//kFauQtqI/dSCCuerGXP5LUKKCoSaAseABeR5AkWXO1HUC7e6?= =?Windows-1252?Q?8lYis8TRuxHk4efb8+1qN+8vDAJniuaJnMThaQ3GDoxCaPHahmBqzPYp?= =?Windows-1252?Q?DrWOvtDMwEtoR12QcV/4qiq5+L+aycTU5adUe0afoigXkXvifzvRbf4n?= =?Windows-1252?Q?lIFpB5qfUR4TQVbyyoyrN4pClX1KqvCvCenGpdJPrz8ZXQbmtVOhno8f?= =?Windows-1252?Q?KuWW+VGw22cKLDKuujwbBUl436hMAEpG4kCFtpFBoUXQhfbuiTTHjjWE?= =?Windows-1252?Q?TtmmefYeiPDyiYYxcdPsK2nxIYCR8sm8L/KMV/7nLv8BRbfwrkYjAv+R?= =?Windows-1252?Q?a5JB36YmSOUkTdUUbjOLdR/elhvDjh5+WWqcod/cJo5b0w+LpY7mB86b?= =?Windows-1252?Q?dR6qhvOQIHrHqCI8duAs4gXk6YspDe8cyOOhXtb8UsDzzCY2BcaW4o5o?= =?Windows-1252?Q?iHVuVBz/uX/ZR2R06aXoLz1Xs6U4cpUiLr5+PjTLFoCsBHoOxfEq7O3v?= =?Windows-1252?Q?ng1n/YTNvlOySJCEKPcWiGrc+nFogSmZWRU0/iYdHUJFbxdi48meuo20?= =?Windows-1252?Q?kuH9evyH7ZLZR8bwIvL4ZbM+CWRi+rkaTGmveU7nyol5KaE0bLef5Ksx?= =?Windows-1252?Q?9BO1xswvopMdoT9bPyq7qtwra2oa3bdH3Xwy7HiOUVaIfZry0rlMANAv?= =?Windows-1252?Q?NgRTNwXq9nWk+wYWP2lqw?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB2049;6:qfkdxZu0vp/GR7Tla8MpE4b6x5PPXOwODCdSvol/Mjs4LdT1BNDzGcMNnkRsk32m+6mXJ4GGFVzRAVwa0KpVhkFjlflwWSB82YRWIIMFVN8+JUiTnfD0RyzBpBIvPztfLWFRQU0nKMm7lQOWNY2LfHcHSrBlRymqmOSMY1KpGaWVQpvyHhOivLUubzxJMWxrWHNajshKFL4XZSbbIYFeMLZ+Da4VA/hj7KCF0lz9yzA+W6KbEpb7SH04H0j5oyF1KODmtszaNbDgJdLBuMlaaOOu9s7SxLkhfj1VOJi26JjrrTyFKaEHbSry7gY03puxz6QlZxZ5fXYYApGEbTThlg==;5:zBL54zEeyazaApmDD8ZkAHqn0cJ6C3l0khHkylt+L/X3Pwq9GZpsJoc5T3Ip17CcO6cQF3GoHgWo+F9npMNcjsuwyBPB7OD1W9Ze+G2RWRo+BIQRj5mZjSrsfCdew4rtxIx7QucdJuifkP0YOov2lg==;24:JVBO4NRtWWFrq4Ca4mgLXqcRZdBweFtQr2+VwP3F4IC8GENkHJB9PCVGMQ48H/bv1o9Sgv7lObsHbcHuV2NErdya/9cxyXsiMbRVqkvMWrA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM5PR0801MB2049;7:3OfjrfpBB+Teboztc+HyxOm3npPy0pmXEwnT0xLy00ikat3BW2Szbc9GpYWWu9Nb9/D8lFTVMSzjowDgmQ19RTlkhnJYiqgSNnCWQMdq8K5+XjBoFqn+pUYo4WEHI0JYtNC1xMFEss6uWNsu+vfZ4fh6DcWXXNFJH2HzEcv880IpL6M6OZnW8C2G/e9CerrnopMScGvfsy2hEWdt5JmvhVGr09A4bIlB4b/u/TryvFDT78i4EtVwgLhp0cQIfEUHi7qoITST1ieEs30udhkcntx6HAJpS5IlN1llVGbhQR7iGYT/7BbJ41VM8T1hTfkvCvqOtcTU1gM+CUzCYcDSU91Q7Z0fmxAkdyPUpJa34so=;20:KdT4Zw7T+FptL2RvhhXcE/KhwA4CaVe6P8cQlRbbcx2ON+4jl2ZM79J9eRxL3TM/RItYWr5fECyuUJu5p4EEPA9jkfcWAl2+5XVAhR2q3eLuPJJXtLNoq1QduXaJtFfZO9up2m91K7DN97i4ezbB1vPDOZKC0BeMunwpokNe0Zo= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2016 16:26:50.3415 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2049 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/30/2016 11:50 AM, Andrey Ryabinin wrote: > It could be not possible to freeze coredumping task when it waits > for 'core_state->startup' completion, because threads are frozen > in get_signal() before they got a chance to complete 'core_state->startup'. > > Use freezer_do_not_count() to tell freezer to ignore coredumping > task while it waits for core_state->startup completion. > > Signed-off-by: Andrey Ryabinin > Cc: stable@vger.kernel.org > --- Ping. Can someone apply this please? > fs/coredump.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/coredump.c b/fs/coredump.c > index 281b768..eb9c92c 100644 > --- a/fs/coredump.c > +++ b/fs/coredump.c > @@ -1,6 +1,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -423,7 +424,9 @@ static int coredump_wait(int exit_code, struct core_state *core_state) > if (core_waiters > 0) { > struct core_thread *ptr; > > + freezer_do_not_count(); > wait_for_completion(&core_state->startup); > + freezer_count(); > /* > * Wait for all the threads to become inactive, so that > * all the thread context (extended register state, like >