From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E62F2C433F5 for ; Tue, 25 Jan 2022 15:41:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1455395AbiAYPlx (ORCPT ); Tue, 25 Jan 2022 10:41:53 -0500 Received: from foss.arm.com ([217.140.110.172]:51224 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354426AbiAYPj3 (ORCPT ); Tue, 25 Jan 2022 10:39:29 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B3CCBD6E; Tue, 25 Jan 2022 07:39:27 -0800 (PST) Received: from [10.32.33.50] (e121896.warwick.arm.com [10.32.33.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3A5683F793; Tue, 25 Jan 2022 07:39:26 -0800 (PST) Subject: Re: [RFC V1 11/11] perf: Capture branch privilege information To: Anshuman Khandual , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Catalin Marinas , Will Deacon , Mark Rutland , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org, Jiri Olsa , Namhyung Kim References: <1642998653-21377-1-git-send-email-anshuman.khandual@arm.com> <1642998653-21377-12-git-send-email-anshuman.khandual@arm.com> From: James Clark Message-ID: <82d586d3-358b-724b-0eac-7fb5c6e03efb@arm.com> Date: Tue, 25 Jan 2022 15:39:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <1642998653-21377-12-git-send-email-anshuman.khandual@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/01/2022 04:30, Anshuman Khandual wrote: > Platforms like arm64 could capture privilege level information for all the > branch records. Hence this adds a new element in the struct branch_entry to > record the privilege level information, which could be requested through a > new event.attr.branch_sample_type flag PERF_SAMPLE_BRANCH_PRIV_SAVE. While > here, update the BRBE driver as required. > > Cc: Will Deacon > Cc: Mark Rutland > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-perf-users@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > drivers/perf/arm_pmu_brbe.c | 28 ++++++++++++++++++++++++ > include/linux/perf_event.h | 5 +++++ > include/uapi/linux/perf_event.h | 13 ++++++++++- > tools/include/uapi/linux/perf_event.h | 13 ++++++++++- > tools/perf/Documentation/perf-record.txt | 1 + > tools/perf/util/parse-branch-options.c | 1 + > 6 files changed, 59 insertions(+), 2 deletions(-) > [...] > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > index 361fdc6b87a0..4d77710f7a4e 100644 > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -204,6 +204,8 @@ enum perf_branch_sample_type_shift { > > PERF_SAMPLE_BRANCH_HW_INDEX_SHIFT = 17, /* save low level index of raw branch records */ > > + PERF_SAMPLE_BRANCH_PRIV_SAVE_SHIFT = 18, /* save privillege mode */ privillege -> privilege > + > PERF_SAMPLE_BRANCH_MAX_SHIFT /* non-ABI */ > }; > > @@ -233,6 +235,8 @@ enum perf_branch_sample_type { > > PERF_SAMPLE_BRANCH_HW_INDEX = 1U << PERF_SAMPLE_BRANCH_HW_INDEX_SHIFT, > > + PERF_SAMPLE_BRANCH_PRIV_SAVE = 1U << PERF_SAMPLE_BRANCH_PRIV_SAVE_SHIFT, > + Can you also add the new entry to the perf verbose printer otherwise it looks like it's not being set on branch_sample_type (as in when using ./perf record -j any_call,u,priv -vvv): static void __p_branch_sample_type(char *buf, size_t size, u64 value) { #define bit_name(n) { PERF_SAMPLE_BRANCH_##n, #n } struct bit_names bits[] = { bit_name(USER), bit_name(KERNEL), bit_name(HV), bit_name(ANY), bit_name(ANY_CALL), bit_name(ANY_RETURN), bit_name(IND_CALL), bit_name(ABORT_TX), bit_name(IN_TX), bit_name(NO_TX), bit_name(COND), bit_name(CALL_STACK), bit_name(IND_JUMP), bit_name(CALL), bit_name(NO_FLAGS), bit_name(NO_CYCLES), bit_name(HW_INDEX), { .name = NULL, } }; #undef bit_name __p_bits(buf, size, value, bits); } PERF_SAMPLE_BRANCH_TYPE_SAVE_SHIFT is also missing so it probably makes sense to add it at the same time as that was expanded for BRBE. > PERF_SAMPLE_BRANCH_MAX = 1U << PERF_SAMPLE_BRANCH_MAX_SHIFT, > }; > > @@ -265,6 +269,12 @@ enum { > PERF_BR_MAX, > }; > > +enum { > + PERF_BR_USER = 0, > + PERF_BR_KERNEL = 1, > + PERF_BR_HV = 2, > +}; > + > #define PERF_SAMPLE_BRANCH_PLM_ALL \ > (PERF_SAMPLE_BRANCH_USER|\ > PERF_SAMPLE_BRANCH_KERNEL|\ > @@ -1377,7 +1387,8 @@ struct perf_branch_entry { > abort:1, /* transaction abort */ > cycles:16, /* cycle count to last branch */ > type:6, /* branch type */ > - reserved:38; > + priv:2, /* privilege level */ > + reserved:36; > }; > > union perf_sample_weight { > diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h > index 9a82b8aaed93..a2208400b0b9 100644 > --- a/tools/include/uapi/linux/perf_event.h > +++ b/tools/include/uapi/linux/perf_event.h > @@ -204,6 +204,8 @@ enum perf_branch_sample_type_shift { > > PERF_SAMPLE_BRANCH_HW_INDEX_SHIFT = 17, /* save low level index of raw branch records */ > > + PERF_SAMPLE_BRANCH_PRIV_SAVE_SHIFT = 18, /* save privillege mode */ > + > PERF_SAMPLE_BRANCH_MAX_SHIFT /* non-ABI */ > }; > > @@ -233,6 +235,8 @@ enum perf_branch_sample_type { > > PERF_SAMPLE_BRANCH_HW_INDEX = 1U << PERF_SAMPLE_BRANCH_HW_INDEX_SHIFT, > > + PERF_SAMPLE_BRANCH_PRIV_SAVE = 1U << PERF_SAMPLE_BRANCH_PRIV_SAVE_SHIFT, > + > PERF_SAMPLE_BRANCH_MAX = 1U << PERF_SAMPLE_BRANCH_MAX_SHIFT, > }; > > @@ -265,6 +269,12 @@ enum { > PERF_BR_MAX, > }; > > +enum { > + PERF_BR_USER = 0, > + PERF_BR_KERNEL = 1, > + PERF_BR_HV = 2, > +}; > + > #define PERF_SAMPLE_BRANCH_PLM_ALL \ > (PERF_SAMPLE_BRANCH_USER|\ > PERF_SAMPLE_BRANCH_KERNEL|\ > @@ -1377,7 +1387,8 @@ struct perf_branch_entry { > abort:1, /* transaction abort */ > cycles:16, /* cycle count to last branch */ > type:6, /* branch type */ > - reserved:38; > + priv:2, /* privilege level */ > + reserved:36; > }; > > union perf_sample_weight { > diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt > index 9ccc75935bc5..3e33686977a1 100644 > --- a/tools/perf/Documentation/perf-record.txt > +++ b/tools/perf/Documentation/perf-record.txt > @@ -387,6 +387,7 @@ following filters are defined: > - abort_tx: only when the target is a hardware transaction abort > - cond: conditional branches > - save_type: save branch type during sampling in case binary is not available later > + - priv: save privilege state during sampling in case binary is not available later > > + > The option requires at least one branch type among any, any_call, any_ret, ind_call, cond. > diff --git a/tools/perf/util/parse-branch-options.c b/tools/perf/util/parse-branch-options.c > index bb4aa88c50a8..00588b9db474 100644 > --- a/tools/perf/util/parse-branch-options.c > +++ b/tools/perf/util/parse-branch-options.c > @@ -32,6 +32,7 @@ static const struct branch_mode branch_modes[] = { > BRANCH_OPT("call", PERF_SAMPLE_BRANCH_CALL), > BRANCH_OPT("save_type", PERF_SAMPLE_BRANCH_TYPE_SAVE), > BRANCH_OPT("stack", PERF_SAMPLE_BRANCH_CALL_STACK), > + BRANCH_OPT("priv", PERF_SAMPLE_BRANCH_PRIV_SAVE), > BRANCH_END > }; > >