From: Chao Yu <yuchao0@huawei.com>
To: Chao Yu <chao@kernel.org>, <jaegeuk@kernel.org>
Cc: <linux-f2fs-devel@lists.sourceforge.net>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] f2fs: fix to check inline_xattr_size boundary correctly
Date: Mon, 4 Mar 2019 14:39:06 +0800 [thread overview]
Message-ID: <82ef0ff8-452c-1894-6776-41c70ad7654b@huawei.com> (raw)
In-Reply-To: <20190214160825.4973-1-chao@kernel.org>
Hi Jaegeuk,
On 2019/2/15 0:08, Chao Yu wrote:
> ---
> v2:
> - fix lower bound check, inline xattr size should be larger than
> xattr_header's size at least.
...
> + if (F2FS_OPTION(sbi).inline_xattr_size <
> + sizeof(struct f2fs_xattr_header) / sizeof(__le32)
No sure we should set this low bound as above... now I guess original
non-zero check is enough.
How do you think of setting inline_xattr_size range as
(0, MAX_INLINE_XATTR_SIZE]?
Thanks,
next prev parent reply other threads:[~2019-03-04 6:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 16:08 [PATCH v2] f2fs: fix to check inline_xattr_size boundary correctly Chao Yu
2019-03-04 6:39 ` Chao Yu [this message]
2019-03-06 6:32 ` [f2fs-dev] " Chao Yu
2019-03-12 18:50 ` Jaegeuk Kim
2019-03-13 1:23 ` Chao Yu
2019-03-13 2:03 ` Jaegeuk Kim
2019-03-13 2:14 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82ef0ff8-452c-1894-6776-41c70ad7654b@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).