From: <Eugen.Hristev@microchip.com>
To: <wsa@the-dreams.de>, <peda@axentia.se>, <mark.rutland@arm.com>,
<Ludovic.Desroches@microchip.com>, <linux-i2c@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <alexandre.belloni@bootlin.com>,
<robh+dt@kernel.org>
Cc: <Nicolas.Ferre@microchip.com>
Subject: Re: [PATCH v5 0/9] i2c: add support for filters
Date: Mon, 14 Oct 2019 07:01:40 +0000 [thread overview]
Message-ID: <82f83640-607b-d888-a268-a54b9753e3c4@microchip.com> (raw)
In-Reply-To: <c17182ac-67dd-d11f-5daf-066bf446b969@microchip.com>
On 07.10.2019 10:47, Eugen Hristev wrote:
>
>
> On 11.09.2019 11:24, Eugen Hristev - M18282 wrote:
>> From: Eugen Hristev <eugen.hristev@microchip.com>
>>
>> Hello,
>>
>> This series adds support for analog and digital filters for i2c
>> controllers
>>
>> This series is based on the series:
>> [PATCH v2 0/9] i2c: at91: filters support for at91 SoCs
>> and later
>> [PATCH v4 0/9] i2c: add support for filters
>> and enhanced to add the bindings for all controllers plus an extra
>> bindings
>> for the width of the spikes in nanoseconds (digital filters) and cut-off
>> frequency (analog filters)
>>
>> First, bindings are created for
>> 'i2c-analog-filter'
>> 'i2c-digital-filter'
>> 'i2c-digital-filter-width-ns'
>> 'i2c-analog-filter-cutoff-frequency'
>>
>> The support is added in the i2c core to retrieve filter width/cutoff
>> frequency
>> and add it to the timings structure.
>> Next, the at91 driver is enhanced for supporting digital filter, advanced
>> digital filter (with selectable spike width) and the analog filter.
>>
>> Finally the device tree for two boards are modified to make use of the
>> new properties.
>>
>> This series is the result of the comments on the ML in the direction
>> requested: to make the bindings globally available for i2c drivers.
>>
>> Changes in v5:
>> - renamed i2c-filter-width-ns to i2c-digital-filter-width-ns as this
>> is applicable only to digital filter
>> - created new binding i2c-digital-filter-width-ns for analog filters.
>
> Hello Wolfram and Peter,
>
> Are you happy with the changes in this version? I haven't heard from you
> since this latest update.
> I am interested to know if anymore changes are required or maybe we can
> move further with this support.
>
> Thanks !
> Eugen
>
Gentle ping
>>
>> Changes in v4:
>> - renamed i2c-ana-filter to i2c-analog-filter
>> - renamed i2c-dig-filter to i2c-digital-filter
>>
>> Changes in v3:
>> - made bindings global for i2c controllers and modified accordingly
>> - gave up PADFCDF bit because it's a lack in datasheet
>> - the computation on the width of the spike is based on periph clock
>> as it
>> is done for hold time.
>>
>> Changes in v2:
>> - added device tree bindings and support for enable-ana-filt and
>> enable-dig-filt
>> - added the new properties to the DT for
>> sama5d4_xplained/sama5d2_xplained
>>
>> Eugen Hristev (9):
>> dt-bindings: i2c: at91: add new compatible
>> dt-bindings: i2c: add bindings for i2c analog and digital filter
>> i2c: add support for filters optional properties
>> i2c: at91: add new platform support for sam9x60
>> i2c: at91: add support for digital filtering
>> i2c: at91: add support for advanced digital filtering
>> i2c: at91: add support for analog filtering
>> ARM: dts: at91: sama5d2_xplained: add analog and digital filter for
>> i2c
>> ARM: dts: at91: sama5d4_xplained: add digital filter for i2c
>>
>> Documentation/devicetree/bindings/i2c/i2c-at91.txt | 3 +-
>> Documentation/devicetree/bindings/i2c/i2c.txt | 18 ++++++++
>> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 6 +++
>> arch/arm/boot/dts/at91-sama5d4_xplained.dts | 1 +
>> drivers/i2c/busses/i2c-at91-core.c | 38
>> +++++++++++++++++
>> drivers/i2c/busses/i2c-at91-master.c | 49
>> ++++++++++++++++++++--
>> drivers/i2c/busses/i2c-at91.h | 13 ++++++
>> drivers/i2c/i2c-core-base.c | 6 +++
>> include/linux/i2c.h | 6 +++
>> 9 files changed, 136 insertions(+), 4 deletions(-)
>>
next prev parent reply other threads:[~2019-10-14 7:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 8:24 [PATCH v5 0/9] i2c: add support for filters Eugen.Hristev
2019-09-11 8:24 ` [PATCH v5 1/9] dt-bindings: i2c: at91: add new compatible Eugen.Hristev
2019-09-11 8:24 ` [PATCH v5 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter Eugen.Hristev
2019-09-17 14:28 ` Rob Herring
2019-09-11 8:24 ` [PATCH v5 3/9] i2c: add support for filters optional properties Eugen.Hristev
2019-10-21 15:20 ` Peter Rosin
2019-09-11 8:24 ` [PATCH v5 4/9] i2c: at91: add new platform support for sam9x60 Eugen.Hristev
2019-09-11 8:24 ` [PATCH v5 5/9] i2c: at91: add support for digital filtering Eugen.Hristev
2019-09-11 8:24 ` [PATCH v5 6/9] i2c: at91: add support for advanced " Eugen.Hristev
2019-09-11 8:24 ` [PATCH v5 7/9] i2c: at91: add support for analog filtering Eugen.Hristev
2019-09-11 8:24 ` [PATCH v5 8/9] ARM: dts: at91: sama5d2_xplained: add analog and digital filter for i2c Eugen.Hristev
2019-09-11 8:24 ` [PATCH v5 9/9] ARM: dts: at91: sama5d4_xplained: add " Eugen.Hristev
2019-09-14 19:32 ` [PATCH v5 0/9] i2c: add support for filters Ludovic Desroches
2019-10-07 7:53 ` Eugen.Hristev
2019-10-14 7:01 ` Eugen.Hristev [this message]
2019-10-21 14:05 ` Wolfram Sang
2019-10-21 15:23 ` Peter Rosin
2019-10-23 11:01 ` Eugen.Hristev
2019-10-23 12:19 ` Wolfram Sang
2019-10-24 18:30 ` Wolfram Sang
2019-10-25 10:05 ` Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82f83640-607b-d888-a268-a54b9753e3c4@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).