From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD162C433B4 for ; Thu, 15 Apr 2021 08:38:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A95CC611C0 for ; Thu, 15 Apr 2021 08:38:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231863AbhDOIic (ORCPT ); Thu, 15 Apr 2021 04:38:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231697AbhDOIib (ORCPT ); Thu, 15 Apr 2021 04:38:31 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A908FC061756; Thu, 15 Apr 2021 01:38:06 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 432ED1F42C47 Subject: Re: [PATCH 3/3] arm64: dts: mt8183-kukui: fix dtbs_check warnings To: Matthias Brugger , Nicolas Boichat , matthias.bgg@kernel.org Cc: Hsin-Yi Wang , Fabien Parent , "moderated list:ARM/Mediatek SoC support" , Rob Herring , Devicetree List , linux-arm Mailing List , lkml References: <20210414144643.17435-1-matthias.bgg@kernel.org> <20210414144643.17435-3-matthias.bgg@kernel.org> From: Enric Balletbo i Serra Message-ID: <82fdfa6e-9c4d-7146-fd90-353e350159c2@collabora.com> Date: Thu, 15 Apr 2021 10:37:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias, On 15/4/21 9:47, Matthias Brugger wrote: > Hi Nicolas, > > On 15/04/2021 02:29, Nicolas Boichat wrote: >> On Wed, Apr 14, 2021 at 10:46 PM wrote: >>> >>> From: Matthias Brugger >>> >>> The dsi children don't have any reg property, >> >> Confused, see below. >> >>> so we don't need address and >>> size cells. This makes dtbs_check happy. >>> >>> CC: Hsin-Yi Wang >>> CC: Enric Balletbo i Serra >>> CC: Nicolas Boichat >>> Signed-off-by: Matthias Brugger >>> >>> --- >>> >>> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi >>> index ff56bcfa3370..f4dca6a33168 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi >>> @@ -251,8 +251,7 @@ &cpu7 { >>> >>> &dsi0 { >>> status = "okay"; >>> - #address-cells = <1>; >>> - #size-cells = <0>; >>> + >>> panel: panel@0 { >>> /* compatible will be set in board dts */ >>> reg = <0>; >> >> ^^ isn't that... a reg property? >> > > Yes, that's my fault. I'm not quite sure why we would need this reg property. In > any case also we have it present "dtbs_check W=1" throws the following warning: > mediatek/mt8183.dtsi:1234.22-1246.5: Warning (avoid_unnecessary_addr_size): > /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or > child "reg" property > > > Can you have a look at that? > I think it is needed reg. See at Documentation/devicetree/bindings/display/dsi-controller.yaml Regards, Enric > Regards, > Matthias > >>> -- >>> 2.30.2 >>>