From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: "Namjae Jeon" <namjae.jeon@samsung.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, hch@lst.de, sj1557.seo@samsung.com,
pali.rohar@gmail.com, arnd@arndb.de, viro@zeniv.linux.org.uk,
"'Namjae Jeon'" <linkinjeon@gmail.com>,
"'Sasha Levin'" <sashal@kernel.org>
Subject: Re: [PATCH] exfat: tighten down num_fats check
Date: Sun, 16 Feb 2020 20:41:21 -0500 [thread overview]
Message-ID: <83075.1581903681@turing-police> (raw)
In-Reply-To: <001b01d5e52a$7f029340$7d07b9c0$@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 960 bytes --]
On Mon, 17 Feb 2020 09:37:55 +0900, "Namjae Jeon" said:
> Could you please update error message for the reason why num_fats is allowed
> only 1?
Sure.. No problem..
> > ret = -EINVAL;
> > goto free_bh;
> Let's remove exfat_mirror_bh(), FAT2_start_sector variable and the below
> related codes together.
>
> sbi->FAT2_start_sector = p_bpb->bsx.num_fats == 1 ?
> sbi->FAT1_start_sector :
> sbi->FAT1_start_sector + sbi->num_FAT_sectors;
You might want to hold off on that part for a bit - I've asked Sasha Levin for
input on what exactly Windows does with this, and Pali has a not-obviously-wrong
suggestion on using the second FAT table. The code tracking FAT2_start_sector
looks OK - what would be missing is doing a similar versioning on the FAT
the rest of the code references.
We may end up heaving that code over the side in the end, but let's make
sure we're doing it with more information in hand....
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2020-02-17 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200214232853epcas1p241e47cdc4e0b9b5c603cc6eaa6182360@epcas1p2.samsung.com>
2020-02-14 23:28 ` [PATCH] exfat: tighten down num_fats check Valdis Klētnieks
2020-02-17 0:37 ` Namjae Jeon
2020-02-17 1:41 ` Valdis Klētnieks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83075.1581903681@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=pali.rohar@gmail.com \
--cc=sashal@kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).