From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: trix@redhat.com, tglx@linutronix.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, viresh.kumar@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined
Date: Mon, 18 Jan 2021 16:15:02 +0100 [thread overview]
Message-ID: <830aea92-5ae4-6b04-80c5-349a45feabf9@linaro.org> (raw)
In-Reply-To: <20210118134926.613931-1-trix@redhat.com>
On 18/01/2021 14:49, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> When DEBUG is defined this error occurs
>
> drivers/clocksource/mxs_timer.c:138:1: error:
> expected ‘;’ before ‘}’ token
>
> The preceding statement needs a semicolon.
>
> Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/clocksource/mxs_timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
> index bc96a4cbf26c..55aa6b72d075 100644
> --- a/drivers/clocksource/mxs_timer.c
> +++ b/drivers/clocksource/mxs_timer.c
> @@ -133,7 +133,7 @@ static void mxs_irq_clear(char *state)
> timrot_irq_acknowledge();
>
> #ifdef DEBUG
> - pr_info("%s: changing mode to %s\n", __func__, state)
> + pr_info("%s: changing mode to %s\n", __func__, state);
> #endif /* DEBUG */
Mind to replace by pr_debug and remove the #ifdef ?
> }
>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2021-01-18 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 13:49 [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined trix
2021-01-18 15:15 ` Daniel Lezcano [this message]
2021-01-18 16:22 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=830aea92-5ae4-6b04-80c5-349a45feabf9@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=trix@redhat.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).