From: Evgeniy Polyakov <zbr@ioremap.net>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] w1: omap_hdq: Free resources on error path
Date: Tue, 24 Jan 2017 05:03:29 +0300 [thread overview]
Message-ID: <831651485223409@web7g.yandex.ru> (raw)
In-Reply-To: <20170109001300.3483-1-christophe.jaillet@wanadoo.fr>
Hi Christophe
09.01.2017, 03:13, "Christophe JAILLET" <christophe.jaillet@wanadoo.fr>:
> In case of error returned by '_omap_hdq_reset()', free resources as done
> elsewhere in this function.
>
> This patch slighly changes the semantic of the code. It now propagates the
> error code returned by '_omap_hdq_reset()' instead of returning -EINVAL
> unconditionally.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Looks good to me.
If kernel-janitors@ will not push it upstream feel free to send to to GregKH <greg@kroah.com>
and add me to copy.
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> ---
> drivers/w1/masters/omap_hdq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index bb09de633939..fb190c259607 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -715,7 +715,7 @@ static int omap_hdq_probe(struct platform_device *pdev)
> ret = _omap_hdq_reset(hdq_data);
> if (ret) {
> dev_dbg(&pdev->dev, "reset failed\n");
> - return -EINVAL;
> + goto err_irq;
> }
>
> rev = hdq_reg_in(hdq_data, OMAP_HDQ_REVISION);
> --
> 2.9.3
prev parent reply other threads:[~2017-01-24 2:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 0:13 [PATCH] w1: omap_hdq: Free resources on error path Christophe JAILLET
2017-01-24 2:03 ` Evgeniy Polyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831651485223409@web7g.yandex.ru \
--to=zbr@ioremap.net \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).