From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754667AbcIGNtF (ORCPT ); Wed, 7 Sep 2016 09:49:05 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:33746 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbcIGNtC (ORCPT ); Wed, 7 Sep 2016 09:49:02 -0400 Subject: Re: [PATCH] dma: qcom: Add initialization of axi and core clocks To: Iaroslav Gridin , vinod.koul@intel.com References: <20160830154223.15129-1-voker57@gmail.com> Cc: dan.j.williams@intel.com, andy.gross@linaro.org, stanimir.varbanov@linaro.org, pramod.gurav@linaro.org, arnd@arndb.de, okaya@codeaurora.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Stephen Boyd From: Stanimir Varbanov Message-ID: <83310901-622b-c548-b7ea-e9d20f8b1903@linaro.org> Date: Wed, 7 Sep 2016 16:48:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160830154223.15129-1-voker57@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Iaroslav, Could you Cc linux-arm-msm ML next time. Cc: Stephen and linux-arm-msm Andy, Stephen probably we don't have conclusion about adding those two clocks in bam driver but do you have some better ideas? On 08/30/2016 06:42 PM, Iaroslav Gridin wrote: > From: Voker57 > > These initialization are missing and causing bam not to init > Signed-off-by: Iaroslav Gridin > --- > drivers/dma/qcom/bam_dma.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c > index 03c4eb3..faae0c8 100644 > --- a/drivers/dma/qcom/bam_dma.c > +++ b/drivers/dma/qcom/bam_dma.c > @@ -395,6 +395,8 @@ struct bam_device { > const struct reg_offset_data *layout; > > struct clk *bamclk; > + struct clk *axi_clk; > + struct clk *core_clk; > int irq; > > /* dma start transaction tasklet */ > @@ -1189,6 +1191,25 @@ static int bam_dma_probe(struct platform_device *pdev) > return ret; > } > > + bdev->axi_clk = devm_clk_get(bdev->dev, "axi_clk"); > + if (IS_ERR(bdev->axi_clk)) > + bdev->axi_clk = NULL; > + > + ret = clk_prepare_enable(bdev->axi_clk); > + if (ret) { > + dev_err(bdev->dev, "failed to prepare/enable axi clock\n"); > + return ret; > + } > + > + bdev->core_clk = devm_clk_get(bdev->dev, "core_clk"); > + if (IS_ERR(bdev->core_clk)) > + bdev->core_clk = NULL; > + > + ret = clk_prepare_enable(bdev->core_clk); > + if (ret) { > + dev_err(bdev->dev, "failed to prepare/enable core clock\n"); > + return ret; > + } > ret = bam_init(bdev); > if (ret) > goto err_disable_clk; > regards, Stan -- regards, Stan