From: Stephan Mueller <smueller@chronox.de>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
David Miller <davem@davemloft.net>,
Ofir Drang <Ofir.Drang@arm.com>,
Yael Chemla <Yael.Chemla@arm.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: mark cts(cbc(aes)) as FIPS allowed
Date: Mon, 05 Nov 2018 11:30:12 +0100 [thread overview]
Message-ID: <8348637.N0ntbUeCvJ@tauon.chronox.de> (raw)
In-Reply-To: <CAKv+Gu8x1LRKq4xJTrWfu7vQDPSzxYwEYGXG_o3Xv+Zsch9S-g@mail.gmail.com>
Am Montag, 5. November 2018, 11:20:28 CET schrieb Ard Biesheuvel:
Hi Ard, Gilad,
> On 5 November 2018 at 10:18, Gilad Ben-Yossef <gilad@benyossef.com> wrote:
> > Hi Stephan,
> >
> > On Mon, Nov 5, 2018 at 10:50 AM Stephan Mueller <smueller@chronox.de>
wrote:
> >> Am Sonntag, 4. November 2018, 11:05:24 CET schrieb Gilad Ben-Yossef:
> >>
> >> Hi Gilad,
> >>
> >> > As per Sp800-38A addendum from Oct 2010[1], cts(cbc(aes)) is
> >> > allowed as a FIPS mode algorithm. Mark it as such.
> >> >
> >> > [1] https://csrc.nist.gov/publications/detail/sp/800-38a/addendum/final
> >>
> >> There are several types of CTS approaches. Only three of those are listed
> >> in the SP800-38A addendum. The source code only refers to some RFCs.
> >>
> >> Did you check whether the CTS implementation matches one or more of the
> >> types listed in the addendum? If yes, may I suggest to add a small
> >> statement in the code noting this fact?
> >
> > Yes, AFAIK the software implements CBC-CS3 as described in the document.
> > You have a very good point about this not document anywhere. I will
> > send a patch.
>
> I agree that it makes sense to document this.
Thanks for adding this. With this statement, the initial patch of adding the
fips_allowed flag is:
Reviewed-by: Stephan Mueller <smueller@chronox.de>
Ciao
Stephan
next prev parent reply other threads:[~2018-11-05 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 10:05 [PATCH] crypto: mark cts(cbc(aes)) as FIPS allowed Gilad Ben-Yossef
2018-11-05 8:50 ` Stephan Mueller
2018-11-05 9:18 ` Gilad Ben-Yossef
2018-11-05 10:20 ` Ard Biesheuvel
2018-11-05 10:30 ` Stephan Mueller [this message]
2018-11-09 9:54 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8348637.N0ntbUeCvJ@tauon.chronox.de \
--to=smueller@chronox.de \
--cc=Ofir.Drang@arm.com \
--cc=Yael.Chemla@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=gilad@benyossef.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).