* linux-next: build failure after merge of the pstore tree
@ 2018-08-03 1:00 Stephen Rothwell
2018-08-03 2:56 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2018-08-03 1:00 UTC (permalink / raw)
To: Kees Cook
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Geliang Tang
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
Hi Kees,
After merging the pstore tree, today's linux-next build (x86_64
allmodconfig) failed like this:
fs/pstore/platform.o: In function `zbufsize_zstd':
platform.c:(.text+0x172): undefined reference to `ZSTD_compressBound'
Caused by commit
48ed452ca6ad ("pstore: add zstd compression support")
I have used the pstore tree from next-20180802 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build failure after merge of the pstore tree
2018-08-03 1:00 linux-next: build failure after merge of the pstore tree Stephen Rothwell
@ 2018-08-03 2:56 ` Kees Cook
2018-08-03 9:16 ` [PATCH] pstore: set PSTORE_ZSTD_COMPRESS to bool Geliang Tang
0 siblings, 1 reply; 4+ messages in thread
From: Kees Cook @ 2018-08-03 2:56 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Geliang Tang
On Thu, Aug 2, 2018 at 6:00 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Kees,
>
> After merging the pstore tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> fs/pstore/platform.o: In function `zbufsize_zstd':
> platform.c:(.text+0x172): undefined reference to `ZSTD_compressBound'
>
> Caused by commit
>
> 48ed452ca6ad ("pstore: add zstd compression support")
Yikes. I have no idea how this slipped through. allmodconfig builds
are my standard sanity-check but I clearly made some kind of error in
my scripting.
I'll get it fixed. Thanks!
-Kees
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] pstore: set PSTORE_ZSTD_COMPRESS to bool
2018-08-03 2:56 ` Kees Cook
@ 2018-08-03 9:16 ` Geliang Tang
2018-08-04 2:05 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: Geliang Tang @ 2018-08-03 9:16 UTC (permalink / raw)
To: Kees Cook, Anton Vorontsov, Colin Cross, Tony Luck, Stephen Rothwell
Cc: Geliang Tang, linux-kernel, lkp
Fix build error:
fs/pstore/platform.o: In function `zbufsize_zstd':
>> platform.c:(.text+0x172): undefined reference to `ZSTD_compressBound'
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
fs/pstore/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig
index 63cf4813559a..503086f7f7c1 100644
--- a/fs/pstore/Kconfig
+++ b/fs/pstore/Kconfig
@@ -51,7 +51,7 @@ config PSTORE_842_COMPRESS
This option enables 842 compression algorithm support.
config PSTORE_ZSTD_COMPRESS
- tristate "zstd compression"
+ bool "zstd compression"
depends on PSTORE
select CRYPTO_ZSTD
help
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pstore: set PSTORE_ZSTD_COMPRESS to bool
2018-08-03 9:16 ` [PATCH] pstore: set PSTORE_ZSTD_COMPRESS to bool Geliang Tang
@ 2018-08-04 2:05 ` Kees Cook
0 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2018-08-04 2:05 UTC (permalink / raw)
To: Geliang Tang
Cc: Anton Vorontsov, Colin Cross, Tony Luck, Stephen Rothwell, LKML,
kbuild test robot
On Fri, Aug 3, 2018 at 2:16 AM, Geliang Tang <geliangtang@gmail.com> wrote:
> Fix build error:
>
> fs/pstore/platform.o: In function `zbufsize_zstd':
>>> platform.c:(.text+0x172): undefined reference to `ZSTD_compressBound'
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Thanks! I'll squash this into the original commit.
-Kees
> ---
> fs/pstore/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig
> index 63cf4813559a..503086f7f7c1 100644
> --- a/fs/pstore/Kconfig
> +++ b/fs/pstore/Kconfig
> @@ -51,7 +51,7 @@ config PSTORE_842_COMPRESS
> This option enables 842 compression algorithm support.
>
> config PSTORE_ZSTD_COMPRESS
> - tristate "zstd compression"
> + bool "zstd compression"
> depends on PSTORE
> select CRYPTO_ZSTD
> help
> --
> 2.17.1
>
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-04 2:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-03 1:00 linux-next: build failure after merge of the pstore tree Stephen Rothwell
2018-08-03 2:56 ` Kees Cook
2018-08-03 9:16 ` [PATCH] pstore: set PSTORE_ZSTD_COMPRESS to bool Geliang Tang
2018-08-04 2:05 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).