From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, TRACKER_ID,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD71BC43461 for ; Tue, 20 Apr 2021 21:22:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA3BC613FC for ; Tue, 20 Apr 2021 21:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234121AbhDTVXU (ORCPT ); Tue, 20 Apr 2021 17:23:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233896AbhDTVXQ (ORCPT ); Tue, 20 Apr 2021 17:23:16 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79425C06138B for ; Tue, 20 Apr 2021 14:22:44 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id o9-20020a1c41090000b029012c8dac9d47so90863wma.1 for ; Tue, 20 Apr 2021 14:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kQP1W0MBWimzZ3NHtFo9wJkMkPBAuGsB/TCIhzxFq2s=; b=rzuVUTTZ+oUsaLSGlch2El9svn+1gJeN2CTAM2dlFJalEknnqY8jieUoKJMandXYw5 QZfWrO/fCtAS4Xwwq2TXM9Iy3uRy8QH+nuli3JqOjJc7EuPcVvIffhlAvN97Fz34l8ia WH3lI4+K1dKIYEAqzYnvbfvtHE9IR4bgWqp6+CPXN5V37w7Huz1aHSniLIckyAujhYA1 Z+1oizpgsPEIJqHLH4PvviEpK8DXrZj0iSCkGaMlUu6Nf1knvPWqKBMcnPfoq10ElgCI cmqTrIXD4kaQxJBtEfEFBAW+/ocrCUe+xYqD1l7Zw86HEs4V28M5Ahw7GfD+74LC9gXa o11A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kQP1W0MBWimzZ3NHtFo9wJkMkPBAuGsB/TCIhzxFq2s=; b=hyq4vJw8/dFKS2y4v6SDsL+NeXIIxEGjjZU1J2zdR+jLNU8IJPrsUvSXMPW5OPHs7G O+r+UcSoGNDcOYjw74oxWJcMwY1K0A6QSeA0mbP2vK37fE70+iFjKqj3B9YsYaTR9zsa yzTzgIqGM5rB1TiPTGQ3xHpS7/Ogi7jegBMocqJ3oJcs6O3Zy43N0HRV8XF3V7WKGTAx oN4HPx//CywoZgf0iOQDMJa7gWAjODZMehSKEUEdsSEEhCrV/5Xw6sx3pnwhdsp1P4w2 jQglz/rnZpI/xUA2YOaen1HHzkxQF2qg5meRX1O4qhH4LCE0htZKolE5LN5mDx5vOav5 /dKg== X-Gm-Message-State: AOAM532xfV4nWSlaeqU0EkQRJNUxMXhmk4prnRERCSTEWOGKIeinuOOL C9XVYD8XHo5oJlInAeYyvdMkwQ== X-Google-Smtp-Source: ABdhPJy16FwFXiDGc9r0CAAjvwJ8hNKS+OrtXiZvmcPPiEFLV6whPzFusug3HluJUQV47Qg5SULmPg== X-Received: by 2002:a1c:4089:: with SMTP id n131mr6389622wma.77.1618953763027; Tue, 20 Apr 2021 14:22:43 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:d985:3a3b:ec32:bdfe? ([2a01:e34:ed2f:f020:d985:3a3b:ec32:bdfe]) by smtp.googlemail.com with ESMTPSA id z15sm267741wrv.39.2021.04.20.14.22.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Apr 2021 14:22:42 -0700 (PDT) Subject: Re: [v3,1/3] thermal: mediatek: Relocate driver to mediatek folder To: Michael Kao , Zhang Rui , linux-pm@vger.kernel.org, srv_heupstream@mediatek.com Cc: Eduardo Valentin , Rob Herring , Mark Rutland , Matthias Brugger , hsinyi@chromium.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20210312034018.17437-1-michael.kao@mediatek.com> <20210312034018.17437-2-michael.kao@mediatek.com> From: Daniel Lezcano Message-ID: <836581c1-0738-8e42-b168-b54d0bd078a5@linaro.org> Date: Tue, 20 Apr 2021 23:22:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210312034018.17437-2-michael.kao@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/2021 04:40, Michael Kao wrote: > Add Mediatek proprietary folder to upstream more thermal zone and cooler > drivers. Relocate the original thermal controller driver to it and rename > as soc_temp.c to show its purpose more clearly. We already know the purpose :) soc_temp gives no additional information. Either keep the name or give the hardware sensor name. It is a driver directory. > Signed-off-by: Michael Kao > --- > drivers/thermal/Kconfig | 14 ++++------- > drivers/thermal/Makefile | 2 +- > drivers/thermal/mediatek/Kconfig | 23 +++++++++++++++++++ > drivers/thermal/mediatek/Makefile | 1 + > .../{mtk_thermal.c => mediatek/soc_temp.c} | 0 [ ... ] vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv > +config MTK_THERMAL > + tristate "Mediatek thermal drivers" > + depends on THERMAL_OF > + help > + This is the option for Mediatek thermal software > + solutions. Please enable corresponding options to > + get temperature information from thermal sensors or > + turn on throttle mechaisms for thermal mitigation. > + > +if MTK_THERMAL ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ All the above not needed. > +config MTK_SOC_THERMAL > + tristate "Temperature sensor driver for mediatek SoCs" > + depends on HAS_IOMEM > + depends on NVMEM > + depends on RESET_CONTROLLER > + help > + Enable this option if you want to get SoC temperature > + information for Mediatek platforms. This driver > + configures thermal controllers to collect temperature > + via AUXADC interface. > + > +endif > diff --git a/drivers/thermal/mediatek/Makefile b/drivers/thermal/mediatek/Makefile > new file mode 100644 > index 000000000000..f75313ddce5e > --- /dev/null > +++ b/drivers/thermal/mediatek/Makefile > @@ -0,0 +1 @@ > +obj-$(CONFIG_MTK_SOC_THERMAL) += soc_temp.o > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mediatek/soc_temp.c > similarity index 100% > rename from drivers/thermal/mtk_thermal.c > rename to drivers/thermal/mediatek/soc_temp.c -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog