From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751230AbdAPITL (ORCPT ); Mon, 16 Jan 2017 03:19:11 -0500 Received: from mail-ve1eur01on0071.outbound.protection.outlook.com ([104.47.1.71]:47270 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751159AbdAPITI (ORCPT ); Mon, 16 Jan 2017 03:19:08 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=tariqt@mellanox.com; Subject: Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants To: Michal Hocko , Andrew Morton References: <20170112153717.28943-1-mhocko@kernel.org> <20170112153717.28943-6-mhocko@kernel.org> CC: Vlastimil Babka , David Rientjes , Mel Gorman , Johannes Weiner , Al Viro , , LKML , Michal Hocko , Martin Schwidefsky , Heiko Carstens , Herbert Xu , Anton Vorontsov , Colin Cross , Kees Cook , Tony Luck , "Rafael J. Wysocki" , Ben Skeggs , Kent Overstreet , Santosh Raspatur , Hariprasad S , Yishai Hadas , Dan Williams , Oleg Drokin , Andreas Dilger , Boris Ostrovsky , David Sterba , "Yan, Zheng" , Ilya Dryomov , Alexei Starovoitov , Eric Dumazet , From: Tariq Toukan Message-ID: <836c370c-f8ff-d682-f457-0ad0da622068@mellanox.com> Date: Mon, 16 Jan 2017 10:18:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170112153717.28943-6-mhocko@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: DB6PR0501CA0019.eurprd05.prod.outlook.com (10.172.232.157) To HE1PR0501MB2041.eurprd05.prod.outlook.com (10.167.245.147) X-MS-Office365-Filtering-Correlation-Id: 8b6f88db-7608-4214-3709-08d43de855ea X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR0501MB2041; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2041;3:PnYtzCQ6vLhiy6+7jeJ8HninVGDBzVn3OvRxzJdcS6Dh76JSBfxlFzj7WZyg0wO2mh2gw4DQW/NN6C0MKJDoxUD/cufm9TGAYm2uSQfe8bE4a+opaorg3np00O9iRuIGZo9b9J+WpMvdcpFOAtfy0ram0vZDVroHqmA/Usz5rHzVjCZ03BEPuRdlRJfatvZYeITBVyh7d8tZZOr9D8cLIIPDHJB2NI2+/qea2YHnBlQNFXLj+2Eq7XjtHFMCNQKSZClH9RayMnWEfqFUXqaqEQ== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2041;25:DezyjUCOSbcH+1X+lmD0G4DM1hH4//eoeQW8Z9ox5JAqDP1h8cNA4kjajNFMJLr68WkCd2ik4qLe4hM34RReCtRgZLFnhr0dN5IGsEbr+b8MlUHDYeU9PH53txNjVe0DiNdpFsM7KnmSMVkEBwVjSx9wYOqdFVweWGVQ446KV68Uq0KEqSkvgXCBKyFSkK6lc9YsP2HqgWFZ9Kctdt1d4xGCUYNPDeNupQmx9UGEoeEI7vk3eqj2A+/h+9SCXZTZzq0xcHLFE+PFcUTnU9+wvaUzhhiZrWvY/iTmouy5PgihRFIfje+pd+2Y4rtwOtH2mND6N60x0dPggHbWX6H/CX3a+5dYs8jwgjxh1warYMnbdi3vIo6Hh5QphN7qsz952XWilZ8Ej8bnQrvySfM4CRqUwZGZ0Q9hDZdhPfFmYLS9gm7A5ZsE95rGlorZ2UG3i4cWDIhZmLD41Vj7Liq6LbHepjZQqhnD5AsGlOcKvX4HSXhS4zfR1Bh4NTm+oKVqk/i0RvG4ApyCg1ETr1rR2OqG1O4tFFh4H0RQdxFukeZSZWhQePC+Hgckf8lChfaZeH8Xq3izZ1yiqJOkBGZIK9OjHV68fFY8gzh4TAvzKL5EJnth9HFhfNahFrDqa3jgCcPeMgrCAdyDEeLQEerVstvOpuuHiLKDDn8tiiqa4OJfZFYOiGcz06RS1A3l/ut2vSTA/cJN9ZmKJduKN+gebh5/DqlIMfBFC/cFYeorAZdzmy1MoZpvOj6ISH+mK9vX X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2041;31:N03X/4xbZOzsSi+xoglriOTt1BczmrAXtC3ykiiCcU5HNUFeqYDKA10+Ssp+1McYIeRKwhWY2huW1MceYL2wQkZfflEk4uoKoyYFwODOKuarCSygBjfX25asGdxZ/aJ7DKA9rnRWLFV325WQyrluZiAnZ+42YEL6ON3p8URnaF9qnlAZUNb+FWeEyEnBNpdGqclidr7uaYD7oX2UDF1T9qJjw1s+UB0CzJFaI3R5wBnQbXdp23HY0J/SmyFwbTnRN3I9i9z7TLrqjDJWc7v+rA==;20:dSHcRuhQKWm8R2CY1YAEixfZAgUQr81dVpj/ql6pVvqocK+OkRd2e0qS0Q5ATfzbeAeEQ1fZTwAPZDWXAFyPIgNFV05J/OteN2uJ2PQr1KDnvD4X0JV32hcGo8iCx00sfP3dgz4kiumZMP2kQxa9LVTSaGfVK9cC+orGsMAi9iJaW6QZzuxeVFlRw0BYCUgJ7Eml4E2D1D0cH+3XyRgIzS9EtdVpKlzQVBDE/U1qaaM6KmbD4Xqp9lO/7HR3hF7cb9uRqv3vPbdOzX//cQk30Kuf5axyhaGmi+a+8t1PORzX8B5Xi4rvBZZownWRSNdIZcX1nnwi7amv/TUq3D5tW1H6L1fduQ/QEIq2gB3zpmQntIOXmNa4UGAp4eRB5l7z95xnBcmFl3wCbsAp+Qm40kD8DAV5/1Gc+KzyJCxRkE/R/4yK4HE4OZKFzBNYKCXPQDheJh8EK2MvNAziNHwTgHHKU1mHRnR4e7PiQaJbWU/lNJK8nsPkjqnUMZGW1KI9 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(190383065149520)(104084551191319)(146099531331640)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148);SRVR:HE1PR0501MB2041;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0501MB2041; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2041;4:WEc4WWI2kXdSQlTdw57IbOn/gzzdfTdDn0WEFdIoTKenBmaYciUZGoqm8Rd9QhgleGd49fAIWyZevIL+7ZbRSNxQVOSUFfcboyvbEtSrjF9wL7ZmUbGiXnhDYuihKSIpNoByp9vux+kwfPCJtMw8G0O2k5TmjBdJFeHD2Y3vyAQOHZ0RUf5pS7zi1HXNDcmM3lkLbg0/2NYsLSNpMYnL9fU7WZOlsYCQ/ZjKDs+D03XKp8yaiU153SitoZTrjLgAl+aTC5tI4i17MWCK2EimA+lPWxOhd2xqXtK1jN3eNWRD+5YTkWIKUrHM6WeiWf8a2M2JCgNOJDX1Y4kRX+q97Noo0vIAj5D+6N+Nghy/FYegMmjs/7I6PZWLBJNxd9VYkh9Ggb4g8dKfm0HghsyWkH1GdIJGKAfJmwRoFpnAc96B413qwjQyDd1U80AA2ahY41Ppgt5pTbZwUoAzAKvWXxBgELOI0aqB3XfTOTmzOiU4wqmOSuUB+uM3TL5Umj6Xoe/0u/UabvKwg/A//V994XHKoN2ylk2ziv9ymycN/Ks9N+2F/32DfWrIQmo4hN1KygwXYFli67fSmIwk3DAMUuIeC/+mykgCQ99M2eiG2+mDAmtC+kyvcYT0obkMCiBZ/liu7sWTpLmtaXro7T4aqyJCJ8tPJPnTqleXeHs8aW2bIPjHgjT/9DYdJWk2mjV5IxYk1rh215O56DUQ4UZyEO1lRJ9nTXSsrPSiQHx6Qgh0b8/RIW/kov/t3Yp2/1yeyNHPBhdu0FtSiSk465hHOA== X-Forefront-PRVS: 01894AD3B8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(39450400003)(39840400002)(39850400002)(39410400002)(39860400002)(189002)(199003)(377454003)(24454002)(65826007)(5660300001)(3846002)(36756003)(92566002)(6666003)(2950100002)(7406005)(83506001)(6116002)(305945005)(97736004)(54356999)(27001)(101416001)(7736002)(23746002)(50986999)(189998001)(5001770100001)(7416002)(4001350100001)(76176999)(68736007)(106356001)(42186005)(105586002)(47776003)(4326007)(25786008)(230700001)(31686004)(2906002)(65806001)(66066001)(54906002)(33646002)(64126003)(90366009)(38730400001)(39060400001)(77096006)(6486002)(50466002)(65956001)(81166006)(81156014)(86362001)(8676002)(229853002)(31696002);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0501MB2041;H:[10.8.1.96];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;HE1PR0501MB2041;23:CWQdeJ9QcNwE37qTOhiNDratLiVDLLJ+cn2?= =?Windows-1252?Q?kuGN/syiweX2KWhoHz2eM8koNnAd0/O0ONGiJqhX+Oczl6BfgMF5b7Z5?= =?Windows-1252?Q?kcE4mHeoOdPTH83MeS4xa3N0KwrBCgGMkJAxG9GsfQTHVftTSw7iPabk?= =?Windows-1252?Q?caDMspMBjJRuQ7EPwybKSM4QW6dR65fjAX4BXT3WY3S0VtAsusKQJILw?= =?Windows-1252?Q?ZWDAGARLMvGU79phumTCLgD1hO/9gl5WY+n+iNObYiUOiDl9stc2aXiY?= =?Windows-1252?Q?5yq6UGu+1pGNDDqpV9pqnvxblyCiKfn3e2mdUTCEMZp/6zn1mNbb9kGr?= =?Windows-1252?Q?jTyCPjUYkaNkGW7CWrmuM94XKWS/iXgujMfOBgTR3qdu3BIhHXa7wvFu?= =?Windows-1252?Q?Ile8cplR5d67Uj2iiU+913f6xYYjmjYGEkDrVgvBGT79SJYS8cc+HEY9?= =?Windows-1252?Q?EZ74n6Vanmo4vamw94/pSPeM4nNyN+Ynt6qI1vstlEZnVJeB7wvEGNRq?= =?Windows-1252?Q?RHWqtalWGBicUzTm1NFnaGqSPdRTLruil+dqzRRfUxYURptoISU1Uye1?= =?Windows-1252?Q?vuHMRv4z2O/BRDg7r+69LXjy69aBj76r1SiASp0TonPkm6w3ubzMjiba?= =?Windows-1252?Q?anU+bIQNOUaSxAvMK1QzlDubtUxJs/0I8jve68GNwLy/DsMrt1/AGR2G?= =?Windows-1252?Q?YfNzZO1IKhkRvkc7UGBZyg/VV93Bn9TqaYxsZhBlQQw+Rj97rgoFPxfo?= =?Windows-1252?Q?i6OYi5Uic/CQ2DfhRZqJqbnKzefdnUGAYMWWu0WZ8Y0aAuOk60aPONIA?= =?Windows-1252?Q?T7aVFP+y4Tde5DEHOiCwQTvE2Td772zF8YSBpATVx+kNEunuDF2qCWw3?= =?Windows-1252?Q?z9eKiH7J1qY7g8DOjbnMUJ2sXtzU45fnhe73v48TdbOp/vwZA+IBRs8k?= =?Windows-1252?Q?RTgueWCsGl1S13aIPuZrszcKeeUQqq8HmJemX62W4vvGjpfL9hL70NJw?= =?Windows-1252?Q?eG4aOd7EmkDVO6GljcTvfj0Nf8blikKYsCTfmSweeYOxZEv6K/g7a3Lb?= =?Windows-1252?Q?53SaGvUO7JHyrd9gPICLW2nmaryBJI0cIm3Ig/x2ftXbncGIA55BY0RO?= =?Windows-1252?Q?ga2yMsszWjwzyD/1E+MWm9KPrlzKZDhcegvnoPTYlPSYyDDPScL/iOP6?= =?Windows-1252?Q?Gm39uI16JaLNolYRXjsKiY5KrWLFrWpJZ+VYcdYKNcc5tyf0uAkM3OBg?= =?Windows-1252?Q?X+NdmAMFfbK0Jnbf2ECsygcfnG77Sug60tIAWfwIB81vJh4rU9XBj0Qz?= =?Windows-1252?Q?WL12byp9mIjuWDhd4q/a4tc+czhWeRlZyFjY3XFTt1fBbgDWWgSzXtu1?= =?Windows-1252?Q?Dds9LpJmR6afR89ypcWQYuPxNZo8Lv3vSUQgUIm5IW42fTgqDQao6H2+?= =?Windows-1252?Q?SJoBya4U7aBEuWSl8I/B5yfDD+E5nK0yzMRzAgUk+jIN9vlwu/emRFfF?= =?Windows-1252?Q?GOMOTWhKRRRTw9LkCVgkQlheEuZQNrjoz/bpcyBGeC51LRATauAajzNr?= =?Windows-1252?Q?k373f4FHBmzpuRu29by6bhFKQWiBVkL8g7e2nDJRU9nTtTi2JiAznG8d?= =?Windows-1252?Q?itpokCDT5V+hkz9x2G+KaKSl8C4VVLH6QN/OQUMQwiKrdSBcuUyxj03l?= =?Windows-1252?Q?adX+QtfF5fg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2041;6:1SlUsRx2zcZ4ob+DpEPWSGK2C6jZgEudCzTxp56e2gA49bG0lpPVN0b/vJe6q+T5wNORNiO6PLNh/Yx7/1johw/eqy3wGSn1f92qj9s5zlpWapYbGS05nSvsqXngrQlrPSncfn1BpJgA0gP9Zpyo5tMO8VjBJzwCTgRNXMKp6T5oTRVB3ZziTxP6A85K3wcMEC/j0rdTDcXJq7SG824H/Ly76A+CIcMg0Hvjqq39VxSP4heohrk9m2ibkE7SE6iUFj/dGZ+1klq5mxvdOCm2OyMMSnF3sLqxLupc6mJz5BNOdN2D95EGeZZQS+BGA9yvIJ+LD1nYLKwDr4ex166cT+EfyW8Icv34fUSQ2sGEgS80gNljX/N6VjhxJD7bGz7dU8FJR750yUv1+YWo6zq9Sx9S1/oBeNdo9fa0C3mKczVS67qae1lettpzmRvYUfWrH3ZA7RydJqYpvbiQfRkk+w==;5:+UXhJ+CHlCEkyuoIQwW3tkXmVrrxkXn0CuLoV+ey9LlB2Woq/TapkgNTc3imKIlLamTA2Gms1IvN3/pNhQHoI9rvsgQ/RitfRGFrZ32luY+EVMiUtdYtPkdjDBVd62PrIEHyI+g5wHpV1Rnawo+meA==;24:xCyM81l3T60fB+6BBtWr2AOwZxnQ3sH38GuogrlUzUEr3CKEjgKUhPZ77DTjQ4MNBh+Rvk/G7tDI0M89YAUV9TLKWY4ZoPFgdhTwpeYKez8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2041;7:P7PSTd6k98yqRMZS4f5FtRWAYmkoDRDF67u0PM+oi+/oV5gB2jsiEFd0BBXLWBbNe6WYeiJFKur5pPJu7QTI0GGiBLV12/8VORkks0njeRrNHb4ktBfEMEQ4mfFY8umzG3c97ySUYIkQNkyc6M7NaRXafA23496qOSElza/bArssAs1hTSGxP3T6IUCMa2B3cW97mHgV1tenJQJJ3D9xzS5nJmKrVQRgTtpTP4omjCKXv3Y/SYezKvdn+yZj/GAFN02ktYsA3AIwFnZ9bSfE+vvJqrOIiJMu74cJLg8Kojm+3K208Hfo+D9sF+ZWA+vLhTBvwI884vKseOdQs4LLOkljlvkdh1KV3V0GIwInjG3IQx5/vNeWi0GzNU0cf5UVk/Wd7u1Fqa2USUgvwDl01DS477V8Phs52UDQfNDUDGzry7WbjWs0kdiVNZH9i6RY98cHEUVmkXyh7tfXRPBK/A== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2017 08:19:00.4151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2041 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/2017 5:37 PM, Michal Hocko wrote: > From: Michal Hocko > > There are many code paths opencoding kvmalloc. Let's use the helper > instead. The main difference to kvmalloc is that those users are usually > not considering all the aspects of the memory allocator. E.g. allocation > requests < 64kB are basically never failing and invoke OOM killer to > satisfy the allocation. This sounds too disruptive for something that > has a reasonable fallback - the vmalloc. On the other hand those > requests might fallback to vmalloc even when the memory allocator would > succeed after several more reclaim/compaction attempts previously. There > is no guarantee something like that happens though. > > This patch converts many of those places to kv[mz]alloc* helpers because > they are more conservative. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Herbert Xu > Cc: Anton Vorontsov > Cc: Colin Cross > Cc: Kees Cook > Cc: Tony Luck > Cc: "Rafael J. Wysocki" > Cc: Ben Skeggs > Cc: Kent Overstreet > Cc: Santosh Raspatur > Cc: Hariprasad S > Cc: Tariq Toukan > Cc: Yishai Hadas > Cc: Dan Williams > Cc: Oleg Drokin > Cc: Andreas Dilger > Cc: Boris Ostrovsky > Cc: David Sterba > Cc: "Yan, Zheng" > Cc: Ilya Dryomov > Cc: Alexander Viro > Cc: Alexei Starovoitov > Cc: Eric Dumazet > Cc: netdev@vger.kernel.org > Signed-off-by: Michal Hocko > --- Acked-by: Tariq Toukan For the mlx4 parts. Regards. Tariq