From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D0DCC433E5 for ; Fri, 17 Jul 2020 07:56:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 495BC20704 for ; Fri, 17 Jul 2020 07:56:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NViLlxEk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728125AbgGQH4X (ORCPT ); Fri, 17 Jul 2020 03:56:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726198AbgGQH4V (ORCPT ); Fri, 17 Jul 2020 03:56:21 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6644CC08C5C0 for ; Fri, 17 Jul 2020 00:56:21 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id f139so15876660wmf.5 for ; Fri, 17 Jul 2020 00:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=o5nIopuM74BtlFzAImb/PK0gyySVM6KhH9dqp/om8uc=; b=NViLlxEklhp1mf7knnPOTkE3tfi428+VHQSNEDbHSufq2Kp0CtIaRQ6KLH/dp/bthm 5KB6kGNDHPBndZPUjVblnnJCuGZf5aRnunRSI+4jjCviFmVd6OCmsbIxO8Wz1lZ4gMV7 mo8OG0Z+4l6xUg1vCqprcFAf6fROOuI+9MeoYuRD66Zof1qzxtVhyLLPtpXozMRZImi0 6aaE1etFK/dZtL8XBO/+qgJzFimkfgrPuVuxMGKHD65yVqrQKijg49ibw7kavHy5IL9O JgrA2mSWlNt4z3w2tSzq6FlYyJf+N6qAGTmHUAZa6sNoUVkmaml6SBt0+qk4VI6uX7KD kt+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o5nIopuM74BtlFzAImb/PK0gyySVM6KhH9dqp/om8uc=; b=Poh0YFRJ1F/Bpc1pQ48SjtPtepQe8uCWX42CqmjYK8NbESR6QCt1K+63RfEki/4fX4 NH+hKGTm7E69OqmRswgi9nrxTflt4kTfY04zzxcCeaJWCrunvb3NDeEjA2uYaVyTpDFc xwLdVD/n5OtxX7Mpx8GMNHiP9dnwnV1ml1EvEcSpc8sz7bampyrLku1F6SvM7Z61/pU5 2DvX6UP7uIl0af8/Z6MopOpziDFfGG62UdiDnz13XARLo2FkEz9T4sxOKWy4gdSTYtcB G3r/HKsnGP1rhenRyVe/G7E9yp/ZclaaVQSr97SM6nKQ9PLbeF/t9C9mJhbDFSxJ1OJx Sfog== X-Gm-Message-State: AOAM530cNBV+TkpO+mk2+T3Fv6HZHqttHll1HfrZIcp7CL7i9KYFBJny fz/L0uxnTbrz5+s3wCu/4L/o3w== X-Google-Smtp-Source: ABdhPJyQffzOr3evg0fAENlwAmDQoBs8yLbdDfhUB2Pv/w4X9/+ZCM+homnG3Ny/Q26Zm37J79d9mw== X-Received: by 2002:a1c:9e84:: with SMTP id h126mr7660444wme.61.1594972579968; Fri, 17 Jul 2020 00:56:19 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:9880:a643:3e69:6393? ([2a01:e34:ed2f:f020:9880:a643:3e69:6393]) by smtp.googlemail.com with ESMTPSA id q7sm12848370wrs.27.2020.07.17.00.56.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2020 00:56:19 -0700 (PDT) Subject: Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for calibration data in sun50i_h6_ths_calibrate To: Frank Lee Cc: Frank Lee , Vasily Khoruzhick , Zhang Rui , Amit Kucheria , Maxime Ripard , Chen-Yu Tsai , Linux PM , Linux ARM , Linux Kernel Mailing List , =?UTF-8?B?6buE54OB55Sf?= , liyong@allwinnertech.com References: <4771acd6-ecd3-b8e1-8605-75d78720b1d3@linaro.org> From: Daniel Lezcano Message-ID: <836e1b23-1c75-57fe-6e45-f7141272071c@linaro.org> Date: Fri, 17 Jul 2020 09:56:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/07/2020 09:35, Frank Lee wrote: > On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano > wrote: >> >> On 14/07/2020 09:13, Frank Lee wrote: >>> From: Yangtao Li >>> >>> For sun50i_h6_ths_calibrate(), the data read from nvmem needs a round of >>> calculation. On the other hand, the newer SOC may store other data in >>> the space other than 12bit sensor data. Add mask operation to read data >>> to avoid conversion error. >>> >>> Signed-off-by: Yangtao Li >>> Reviewed-by: Yangtao Li >> >> Can you clarify these SoB ? > > Previously I used 'Signed-off-by: Yangtao Li ', > maybe this should be removed directly? > >> >> Frank Lee==Yangtao Li==frank@allwinnertech.com==tiny.windzz@gmail.com ? >> > > Yeah. You are not supposed to add reviewed-by yourself. Please remove it. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog