From: <Mario.Limonciello@dell.com>
To: <rafael@kernel.org>
Cc: <andy.shevchenko@gmail.com>, <rjw@rjwysocki.net>,
<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [RFC] power/hibernate: Make passing hibernate offsets more friendly
Date: Fri, 2 Mar 2018 13:41:12 +0000 [thread overview]
Message-ID: <836fd1d7923d4432b17607351b302a56@ausx13mpc124.AMER.DELL.COM> (raw)
In-Reply-To: <CAJZ5v0jGr0VP9bNXprvyHfLvvvEgva6S9rAZM8EZEpGw=0PG+g@mail.gmail.com>
> -----Original Message-----
> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael J.
> Wysocki
> Sent: Friday, March 2, 2018 3:43 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>; Rafael J. Wysocki
> <rjw@rjwysocki.net>; ACPI Devel Maling List <linux-acpi@vger.kernel.org>; Linux
> Kernel Mailing List <linux-kernel@vger.kernel.org>
> Subject: Re: [RFC] power/hibernate: Make passing hibernate offsets more friendly
>
> On Wed, Feb 28, 2018 at 9:05 PM, <Mario.Limonciello@dell.com> wrote:
> >
> >
> >> -----Original Message-----
> >> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> >> Sent: Wednesday, February 28, 2018 12:11 PM
> >> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> >> Cc: Rafael J . Wysocki <rjw@rjwysocki.net>; ACPI Devel Maling List <linux-
> >> acpi@vger.kernel.org>; LKML <linux-kernel@vger.kernel.org>
> >> Subject: Re: [RFC] power/hibernate: Make passing hibernate offsets more friendly
> >>
> >> On Wed, Feb 28, 2018 at 7:43 PM, Mario Limonciello
> >> <mario.limonciello@dell.com> wrote:
> >> > Currently the only way to specify a hibernate offset for a swap
> >> > file is on the kernel command line.
> >> >
> >> > This makes some changes to improve:
> >> > 1) Add a new /sys/power/disk_offset that lets userspace specify
> >> > the offset and disk to use when initiating a hibernate cycle.
> >> >
> >> > 2) Adjust /sys/power/resume interpretation to also read in an
> >> > offset.
> >>
> >> Read is okay per se (not consistent though), showing is not.
> >> It might break an ABI.
> >
> > Right this is part of why I was proposing making a new attribute.
> >
> > The current RFC implementation I sent keeps the read output the
> > same for /sys/power/resume.
>
> You also need to retain the write behavior of it.
>
> A new attribute is fine if it helps, but the behavior of the existing
> one cannot change (both sides).
Thanks for your feedback, I'll adjust it as such.
prev parent reply other threads:[~2018-03-02 13:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 17:43 [RFC] power/hibernate: Make passing hibernate offsets more friendly Mario Limonciello
2018-02-28 18:11 ` Andy Shevchenko
2018-02-28 20:05 ` Mario.Limonciello
2018-03-02 9:42 ` Rafael J. Wysocki
2018-03-02 13:41 ` Mario.Limonciello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=836fd1d7923d4432b17607351b302a56@ausx13mpc124.AMER.DELL.COM \
--to=mario.limonciello@dell.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).