linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nadav Amit <namit@vmware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Julien Freche <jfreche@vmware.com>
Subject: Re: [PATCH 1/6] vmw_balloon: bump version number
Date: Wed, 6 Feb 2019 20:39:52 +0000	[thread overview]
Message-ID: <83759B2D-329A-4CBA-84A4-0511398D1AB2@vmware.com> (raw)
In-Reply-To: <20190206164245.GA8466@kroah.com>

> On Feb 6, 2019, at 8:42 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Tue, Feb 05, 2019 at 09:13:31PM -0800, Nadav Amit wrote:
>> Following recent changes.
>> 
>> Signed-off-by: Nadav Amit <namit@vmware.com>
>> ---
>> drivers/misc/vmw_balloon.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
>> index f8240b87df22..7294f305753f 100644
>> --- a/drivers/misc/vmw_balloon.c
>> +++ b/drivers/misc/vmw_balloon.c
>> @@ -34,7 +34,7 @@
>> 
>> MODULE_AUTHOR("VMware, Inc.");
>> MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
>> -MODULE_VERSION("1.5.0.0-k");
>> +MODULE_VERSION("1.6.0.0-k");
> 
> Please just drop this pointless line, it means nothing and is always out
> of date.  It's been removed from many other drivers, and I really don't
> want to see it come back.
> 
> Your driver "version" is the kernel version, full stop.  That's all you
> need to ever worry about.

I understand, and I will inform those who asked for the version bump.

Having said that, I do not see a reference for this policy. I understand
that you removed the MODULE_VERSION from in-kernel drivers, but I also see
that you accepted several drivers last year that used MODULE_VERSION.


  reply	other threads:[~2019-02-06 20:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-06  5:13 [PATCH 0/6] vmw_balloon: 64-bit limit support, compaction, shrinker Nadav Amit
2019-02-06  5:13 ` [PATCH 1/6] vmw_balloon: bump version number Nadav Amit
2019-02-06 16:42   ` Greg Kroah-Hartman
2019-02-06 20:39     ` Nadav Amit [this message]
2019-02-06 21:06       ` Greg Kroah-Hartman
2019-02-06 22:17         ` Nadav Amit
2019-02-06 17:52 ` [PATCH 0/6] vmw_balloon: 64-bit limit support, compaction, shrinker Michael S. Tsirkin
2019-02-06 18:05   ` Nadav Amit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83759B2D-329A-4CBA-84A4-0511398D1AB2@vmware.com \
    --to=namit@vmware.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jfreche@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).