From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756344AbcH2VAG (ORCPT <rfc822;w@1wt.eu>);
        Mon, 29 Aug 2016 17:00:06 -0400
Received: from mail.kmu-office.ch ([178.209.48.109]:58051 "EHLO
        mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754688AbcH2VAE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 Aug 2016 17:00:04 -0400
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Date: Mon, 29 Aug 2016 13:54:50 -0700
From: Stefan Agner <stefan@agner.ch>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        linux-arm-kernel@lists.infradead.org,
        Lucas Stach <l.stach@pengutronix.de>,
        Russell King <linux@arm.linux.org.uk>,
        Sascha Hauer <kernel@pengutronix.de>,
        =?UTF-8?Q?Petr_=C5=A0tetiar?= <ynezz@true.cz>,
        Fabio Estevam <festevam@gmail.com>, Kumar Gala <galak@codeaurora.org>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Joshua Clayton <stillcompiling@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>, Shawn Guo <shawnguo@kernel.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] ARM: dts: imx6: Add support for Toradex Apalis
 iMX6Q/D SoM
In-Reply-To: <97a3d506-35a0-2a15-18ef-2719c0596cc1@mentor.com>
References: <1454688741-4238-1-git-send-email-marcel.ziswiler@toradex.com>
 <1454688741-4238-2-git-send-email-marcel.ziswiler@toradex.com>
 <97a3d506-35a0-2a15-18ef-2719c0596cc1@mentor.com>
Message-ID: <8379c5d41f44fc1b59a5c15650f30c68@agner.ch>
User-Agent: Roundcube Webmail/1.1.3
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016-08-29 06:28, Vladimir Zapolskiy wrote:
> Hi Marcel,
> 
> On 02/05/2016 06:12 PM, Marcel Ziswiler wrote:
>> From: Petr Štetiar <ynezz@true.cz>
>>
>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>> Signed-off-by: Petr Štetiar <ynezz@true.cz>
>> Reviewed-by: Stefan Agner <stefan@agner.ch>
>> ---
>>
> 
> because the change is in mainline now below is kind of out of date
> information, but you may find it helpful.
> 
> [snip]
> 
>> - fixed HDMI DDC (requires GPIO-based bitbanging I2C to be enabled)
> 
> This is not needed.
> 
> [snip]
> 
>> +	/* DDC_I2C: I2C2_SDA/SCL on MXM3 205/207 */
>> +	i2cddc: i2c@0 {
>> +		compatible = "i2c-gpio";
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&pinctrl_i2c_ddc>;
>> +		gpios = <&gpio3 16 GPIO_ACTIVE_HIGH /* sda */
>> +			 &gpio2 30 GPIO_ACTIVE_HIGH /* scl */
>> +			>;
>> +		i2c-gpio,delay-us = <2>;	/* ~100 kHz */
>> +		status = "disabled";
>> +	};
>> +
> 
> This is not needed.
> 
> [snip]
> 
>> +	pinctrl_i2c_ddc: gpioi2cddcgrp {
>> +		fsl,pins = <
>> +			/* DDC bitbang */
>> +			MX6QDL_PAD_EIM_EB2__GPIO2_IO30 0x1b0b0
>> +			MX6QDL_PAD_EIM_D16__GPIO3_IO16 0x1b0b0
>> +		>;
>> +	};
>> +
> 
> Practically you don't need this overcomplicated GPIO-based bitbanging
> to emulate I2C, because the DW HDMI controller has a reduced I2C
> controller on board, you may take a look at its support published here:
> 
>    http://www.spinics.net/lists/dri-devel/msg116308.html
> 
> To utilize it the pads should be set to HDMI function instead of
> I2C or GPIO.

Thanks for the notification! I guess we'd also have to remove...

+&hdmi {
+    ddc-i2c-bus = <&i2cddc>;

...this line...

+    status = "okay";
+};
+
+&i2cddc {
+    status = "okay";
+};

and this from arch/arm/boot/dts/imx6q-apalis-ixora.dts.

--
Stefan