From: <Tudor.Ambarus@microchip.com>
To: <yogeshnarayan.gaur@nxp.com>, <linux-mtd@lists.infradead.org>,
<boris.brezillon@bootlin.com>, <broonie@kernel.org>,
<marek.vasut@gmail.com>, <vigneshr@ti.com>,
<linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>
Cc: <robh@kernel.org>, <mark.rutland@arm.com>, <shawnguo@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<computersforpeace@gmail.com>, <frieder.schrempf@exceet.de>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 3/5] mtd: m25p80: add support of octal mode I/O transfer
Date: Thu, 17 Jan 2019 07:16:01 +0000 [thread overview]
Message-ID: <8381785e-95c2-8dfc-6fac-ea4710b3c943@microchip.com> (raw)
In-Reply-To: <1547546584-5254-4-git-send-email-yogeshnarayan.gaur@nxp.com>
On 01/15/2019 12:05 PM, Yogesh Narayan Gaur wrote:
> Add support for octal mode I/O data transfer based on the controller (spi)
> mode.
> Assign hw-capability mask bits for octal transfer.
>
> Signed-off-by: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> drivers/mtd/devices/m25p80.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index c4a1d04b8c80..651bab6d4e31 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -195,7 +195,14 @@ static int m25p_probe(struct spi_mem *spimem)
> spi_mem_set_drvdata(spimem, flash);
> flash->spimem = spimem;
>
> - if (spi->mode & SPI_RX_QUAD) {
> + if (spi->mode & SPI_RX_OCTAL) {
> + hwcaps.mask |= SNOR_HWCAPS_READ_1_1_8;
> +
> + if (spi->mode & SPI_TX_OCTAL)
> + hwcaps.mask |= (SNOR_HWCAPS_READ_1_8_8 |
> + SNOR_HWCAPS_PP_1_1_8 |
> + SNOR_HWCAPS_PP_1_8_8);
> + } else if (spi->mode & SPI_RX_QUAD) {
> hwcaps.mask |= SNOR_HWCAPS_READ_1_1_4;
>
> if (spi->mode & SPI_TX_QUAD)
>
next prev parent reply other threads:[~2019-01-17 7:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 10:05 [PATCH v7 0/5] spi: add support for octal mode Yogesh Narayan Gaur
2019-01-15 10:05 ` [PATCH v7 1/5] mtd: spi-nor: add opcodes for octal Read/Write commands Yogesh Narayan Gaur
2019-01-19 15:42 ` [v7,1/5] " Boris Brezillon
2019-01-15 10:05 ` [PATCH v7 2/5] mtd: spi-nor: add octal read flag for flash mt35xu512aba Yogesh Narayan Gaur
2019-01-16 6:19 ` Tudor.Ambarus
2019-01-19 15:42 ` [v7,2/5] " Boris Brezillon
2019-01-15 10:05 ` [PATCH v7 3/5] mtd: m25p80: add support of octal mode I/O transfer Yogesh Narayan Gaur
2019-01-17 7:16 ` Tudor.Ambarus [this message]
2019-01-19 15:41 ` [v7,3/5] " Boris Brezillon
2019-01-15 10:05 ` [PATCH v7 4/5] spi: nxp-fspi: add octal mode flag bit for octal support Yogesh Narayan Gaur
2019-01-28 12:26 ` Mark Brown
2019-01-28 12:30 ` Mark Brown
2019-01-15 10:05 ` [PATCH v7 5/5] arm64: dts: lx2160a: update fspi node Yogesh Narayan Gaur
2019-02-01 3:51 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8381785e-95c2-8dfc-6fac-ea4710b3c943@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frieder.schrempf@exceet.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vigneshr@ti.com \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).