From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "willy@infradead.org" <willy@infradead.org>
Cc: "hch@lst.de" <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"dja@axtens.net" <dja@axtens.net>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/vmalloc: Separate put pages and flush VM flags
Date: Thu, 21 Jan 2021 23:57:47 +0000 [thread overview]
Message-ID: <838bda4c00d1a93e5146cf89ac0f42a64f0fc61d.camel@intel.com> (raw)
In-Reply-To: <20210121131932.GO2260413@casper.infradead.org>
On Thu, 2021-01-21 at 13:19 +0000, Matthew Wilcox wrote:
> On Wed, Jan 20, 2021 at 05:41:18PM -0800, Rick Edgecombe wrote:
> > When VM_MAP_PUT_PAGES was added, it was defined with the same value
> > as
> > VM_FLUSH_RESET_PERMS. This doesn't seem like it will cause any big
> > functional problems other than some excess flushing for
> > VM_MAP_PUT_PAGES
> > allocations.
> >
> > Redefine VM_MAP_PUT_PAGES to have its own value. Also, move the
> > comment
> > and remove whitespace for VM_KASAN such that the flags lower down
> > are less
> > likely to be missed in the future.
>
> Er ... I think the problem was that VM_FLUSH_RESET_PERMS was put away
> from
> all the other flags!
Well it wasn't that far away at the time, the VM_KASAN comment and
whitespace got added later. But yes not ideal.
> Why not this?
128 char line, but looks better to me.
prev parent reply other threads:[~2021-01-21 23:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 1:41 [PATCH] mm/vmalloc: Separate put pages and flush VM flags Rick Edgecombe
2021-01-21 2:44 ` Miaohe Lin
2021-01-21 7:08 ` Christoph Hellwig
2021-01-21 13:19 ` Matthew Wilcox
2021-01-21 23:57 ` Edgecombe, Rick P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838bda4c00d1a93e5146cf89ac0f42a64f0fc61d.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dja@axtens.net \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).