From: Helge Deller <deller@gmx.de>
To: Guenter Roeck <linux@roeck-us.net>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: Move pci_dev_is_behind_card_dino to where it is used
Date: Wed, 8 Sep 2021 22:51:27 +0200 [thread overview]
Message-ID: <8392d93e-73d8-0a9e-15e2-db139086fdf0@gmx.de> (raw)
In-Reply-To: <20210908153041.643069-1-linux@roeck-us.net>
On 9/8/21 5:30 PM, Guenter Roeck wrote:
> parisc build test images fail to compile with the following error.
>
> drivers/parisc/dino.c:160:12: error:
> 'pci_dev_is_behind_card_dino' defined but not used
>
> Move the function just ahead of its only caller to avoid the error.
>
> Fixes: 5fa1659105fa ("parisc: Disable HP HSC-PCI Cards to prevent kernel crash")
> Cc: Helge Deller <deller@gmx.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
applied to the parisc tree.
Thanks!
Helge
> ---
> drivers/parisc/dino.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/parisc/dino.c b/drivers/parisc/dino.c
> index 889d7ce282eb..952a92504df6 100644
> --- a/drivers/parisc/dino.c
> +++ b/drivers/parisc/dino.c
> @@ -156,15 +156,6 @@ static inline struct dino_device *DINO_DEV(struct pci_hba_data *hba)
> return container_of(hba, struct dino_device, hba);
> }
>
> -/* Check if PCI device is behind a Card-mode Dino. */
> -static int pci_dev_is_behind_card_dino(struct pci_dev *dev)
> -{
> - struct dino_device *dino_dev;
> -
> - dino_dev = DINO_DEV(parisc_walk_tree(dev->bus->bridge));
> - return is_card_dino(&dino_dev->hba.dev->id);
> -}
> -
> /*
> * Dino Configuration Space Accessor Functions
> */
> @@ -447,6 +438,15 @@ static void quirk_cirrus_cardbus(struct pci_dev *dev)
> DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_CIRRUS, PCI_DEVICE_ID_CIRRUS_6832, quirk_cirrus_cardbus );
>
> #ifdef CONFIG_TULIP
> +/* Check if PCI device is behind a Card-mode Dino. */
> +static int pci_dev_is_behind_card_dino(struct pci_dev *dev)
> +{
> + struct dino_device *dino_dev;
> +
> + dino_dev = DINO_DEV(parisc_walk_tree(dev->bus->bridge));
> + return is_card_dino(&dino_dev->hba.dev->id);
> +}
> +
> static void pci_fixup_tulip(struct pci_dev *dev)
> {
> if (!pci_dev_is_behind_card_dino(dev))
>
prev parent reply other threads:[~2021-09-08 20:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 15:30 [PATCH] parisc: Move pci_dev_is_behind_card_dino to where it is used Guenter Roeck
2021-09-08 20:51 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8392d93e-73d8-0a9e-15e2-db139086fdf0@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).