From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Himanshu Jha <himanshujha199640@gmail.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: Eugen Hristev <eugen.hristev@microchip.com>,
ludovic.desroches@microchip.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
nicolas.ferre@microchip.com,
Maxime Ripard <maxime.ripard@bootlin.com>
Subject: Re: [PATCH 2/2] iio: adc: at91: fix wrong channel number in triggered buffer mode
Date: Sat, 22 Sep 2018 13:51:22 +0100 [thread overview]
Message-ID: <83D84516-8721-4712-B24B-7B1199FAFCC4@jic23.retrosnub.co.uk> (raw)
In-Reply-To: <20180922114849.GA3890@himanshu-Vostro-3559>
On 22 September 2018 12:48:49 BST, Himanshu Jha <himanshujha199640@gmail.com> wrote:
>On Sat, Sep 22, 2018 at 11:36:16AM +0100, Jonathan Cameron wrote:
>> On Fri, 21 Sep 2018 15:26:03 +0800
>> kbuild test robot <lkp@intel.com> wrote:
>>
>> > Hi Eugen,
>> This one is leaving me stumped...
>>
>> Anyone care to point out what I'm missing that is wrong here?
>>
>> Also Eugen, please don't cc stable on a patch directly. It is fine
>to send
>> a backport request once a patch has hit mainline, but before that
>it's just
>> adding noise to a list as they won't take it directly anyway.
>
>Song is correct on this one.
>
>So, just replace the declaration to:
>
> struct iio_chan_spec const *chan;
>
>and then warning goes away...
Good point. Not enough coffee this morning..
Obvious now :)
>
>Another thing, its better not to reply the automated bot and instead to
>the author by changing "From" address. :)
>
>That is what I do often when replying to that thread.
>
>https://lore.kernel.org/lkml/20180921182616.GA2077@himanshu-Vostro-3559/
>
>And it nests properly in the given thread avoiding any noise to kbuild
>bot.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
next prev parent reply other threads:[~2018-09-22 12:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 12:40 [PATCH 1/2] iio: adc: at91: fix acking DRDY irq on simple conversions Eugen Hristev
2018-09-20 12:40 ` [PATCH 2/2] iio: adc: at91: fix wrong channel number in triggered buffer mode Eugen Hristev
2018-09-21 7:26 ` kbuild test robot
2018-09-22 10:36 ` Jonathan Cameron
2018-09-22 11:19 ` Song Qiang
2018-09-22 11:48 ` Himanshu Jha
2018-09-22 12:51 ` Jonathan Cameron [this message]
2018-09-22 10:31 ` [PATCH 1/2] iio: adc: at91: fix acking DRDY irq on simple conversions Jonathan Cameron
2018-09-24 6:19 ` Eugen Hristev
2018-09-24 20:00 ` Jonathan Cameron
2018-09-24 20:27 ` Jonathan Cameron
2018-09-25 6:50 ` Eugen Hristev
2018-09-29 11:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83D84516-8721-4712-B24B-7B1199FAFCC4@jic23.retrosnub.co.uk \
--to=jic23@jic23.retrosnub.co.uk \
--cc=eugen.hristev@microchip.com \
--cc=himanshujha199640@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=maxime.ripard@bootlin.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).