From: Anusha Canchi <quic_anusha@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
<andersson@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <quic_srichara@quicinc.com>, <quic_gokulsri@quicinc.com>,
<quic_sjaganat@quicinc.com>, <quic_kathirav@quicinc.com>,
<quic_arajkuma@quicinc.com>, <quic_poovendh@quicinc.com>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq9574: Enable WPS buttons
Date: Fri, 16 Jun 2023 18:17:19 +0530 [thread overview]
Message-ID: <83aa1135-8e66-b153-ab5c-a23df2bce5f5@quicinc.com> (raw)
In-Reply-To: <4dede8d5-e665-1cf4-ea27-b2ba99f820e2@linaro.org>
On 6/14/2023 4:12 PM, Konrad Dybcio wrote:
>
> On 14.06.2023 10:50, Anusha Rao wrote:
>> Add support for wps buttons on GPIO 37.
>>
>> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
>> ---
>> .../boot/dts/qcom/ipq9574-rdp-common.dtsi | 23 +++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
>> index 999902bc70bd..fd5326dc1773 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
>> @@ -8,6 +8,8 @@
>>
>> /dts-v1/;
>>
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/input/input.h>
>> #include "ipq9574.dtsi"
>>
>> / {
>> @@ -18,6 +20,20 @@
>> chosen {
>> stdout-path = "serial0:115200n8";
>> };
>> +
>> + gpio-keys {
>> + compatible = "gpio-keys";
>> + pinctrl-0 = <&gpio_keys_default>;
>> + pinctrl-names = "default";
>> +
>> + button-wps {
>> + label = "wps";
>> + linux,code = <KEY_WPS_BUTTON>;
>> + gpios = <&tlmm 37 GPIO_ACTIVE_LOW>;
>> + linux,input-type = <1>;
> This line is unnecessary, it's set to 'key' by default. With that:
Okay, will address in the next patch.
Thanks,
Anusha
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> Konrad
>> + debounce-interval = <60>;
>> + };
>> + };
>> };
>>
>> &blsp1_spi0 {
>> @@ -114,6 +130,13 @@
>> drive-strength = <8>;
>> bias-disable;
>> };
>> +
>> + gpio_keys_default: gpio-keys-default-state {
>> + pins = "gpio37";
>> + function = "gpio";
>> + drive-strength = <8>;
>> + bias-pull-up;
>> + };
>> };
>>
>> &xo_board_clk {
prev parent reply other threads:[~2023-06-16 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 8:50 [PATCH 0/2] Add common RDP dtsi file for ipq9574 Anusha Rao
2023-06-14 8:50 ` [PATCH 1/2] arm64: dts: qcom: ipq9574: Add common RDP dtsi file Anusha Rao
2023-06-14 10:40 ` Konrad Dybcio
2023-06-16 12:49 ` Anusha Canchi
2023-06-14 8:50 ` [PATCH 2/2] arm64: dts: qcom: ipq9574: Enable WPS buttons Anusha Rao
2023-06-14 10:42 ` Konrad Dybcio
2023-06-16 12:47 ` Anusha Canchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83aa1135-8e66-b153-ab5c-a23df2bce5f5@quicinc.com \
--to=quic_anusha@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_arajkuma@quicinc.com \
--cc=quic_gokulsri@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_poovendh@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).