linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Harrison <john.c.harrison@intel.com>
To: Colin Ian King <colin.i.king@gmail.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Matthew Brost <matthew.brost@intel.com>,
	<intel-gfx@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] drm/i915/guc: fix spelling mistake "notificaion" -> "notification"
Date: Tue, 25 Jan 2022 10:52:19 -0800	[thread overview]
Message-ID: <83d085f0-8f2e-dc92-dab3-61c0b7677df8@intel.com> (raw)
In-Reply-To: <20220125091359.350918-1-colin.i.king@gmail.com>

On 1/25/2022 01:13, Colin Ian King wrote:
> There is a spelling mistake in a drm_err error message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>

However, note that this message is going to be deleted anyway. Or at 
least dropped down to an informational. Partly, there was confusion over 
how the issue could arise. Partly the firmware bug leading to part of 
the problem has now been fixed and the w/a removed from the driver. 
Cleaning this error up accordingly is on my todo list...

Thanks,
John.


> ---
>   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> index 1331ff91c5b0..1ae3d1f259e3 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
> @@ -3942,7 +3942,7 @@ static void guc_handle_context_reset(struct intel_guc *guc,
>   		guc_context_replay(ce);
>   	} else {
>   		drm_err(&guc_to_gt(guc)->i915->drm,
> -			"Invalid GuC engine reset notificaion for 0x%04X on %s: banned = %d, blocked = %d",
> +			"Invalid GuC engine reset notification for 0x%04X on %s: banned = %d, blocked = %d",
>   			ce->guc_id.id, ce->engine->name, intel_context_is_banned(ce),
>   			context_blocked(ce));
>   	}


      reply	other threads:[~2022-01-25 18:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  9:13 [PATCH][next] drm/i915/guc: fix spelling mistake "notificaion" -> "notification" Colin Ian King
2022-01-25 18:52 ` John Harrison [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d085f0-8f2e-dc92-dab3-61c0b7677df8@intel.com \
    --to=john.c.harrison@intel.com \
    --cc=airlied@linux.ie \
    --cc=colin.i.king@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).