From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Boqun Feng <boqun.feng@gmail.com>, Ingo Molnar <mingo@redhat.com>,
Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] lockdep: report name and key when look_up_lock_class() got confused
Date: Mon, 19 Sep 2022 22:44:16 +0900 [thread overview]
Message-ID: <83fc4085-60cc-fdc6-43ba-ac701cfde80c@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <YyhI93taOenZMHrY@hirez.programming.kicks-ass.net>
On 2022/09/19 19:48, Peter Zijlstra wrote:
> On Mon, Sep 19, 2022 at 09:52:13AM +0900, Tetsuo Handa wrote:
>> Printing this information will be helpful.
>>
>> ------------[ cut here ]------------
>> Looking for class "l2tp_sock" with key l2tp_socket_class, but found a different class "slock-AF_INET6" with the same key
>> WARNING: CPU: 1 PID: 14195 at kernel/locking/lockdep.c:940 look_up_lock_class+0xcc/0x140
>> Modules linked in:
>> CPU: 1 PID: 14195 Comm: a.out Not tainted 6.0.0-rc6-dirty #863
>> Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006
>> RIP: 0010:look_up_lock_class+0xcc/0x140
>>
>> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>
> Urgh, you hitting that WARN enough times to want to improve it seems to
> suggest your machine is quite sick.
My machine is not sick at all. I just wanted this hint for debugging
https://syzkaller.appspot.com/bug?extid=94cc2a66fc228b23f360 .
In a world of debugging without vmcore, printing as much hint as possible is
important. Therefore, WARN_ONCE() is more appreciated than WARN_ON_ONCE().
>
> Anyway, patch is ok I suppose.
Thank you. Please send this patch and
https://lkml.kernel.org/r/9f42e8a5-f809-3f2c-0fda-b7657bc94eb3@I-love.SAKURA.ne.jp
via your tree.
next prev parent reply other threads:[~2022-09-19 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 15:01 [PATCH] lockdep: report name and key when look_up_lock_class() got confused Tetsuo Handa
2022-09-18 18:31 ` Boqun Feng
2022-09-19 0:52 ` [PATCH v2] " Tetsuo Handa
2022-09-19 10:48 ` Peter Zijlstra
2022-09-19 13:44 ` Tetsuo Handa [this message]
2022-09-21 8:01 ` [tip: locking/core] locking/lockdep: Print more debug information - " tip-bot2 for Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fc4085-60cc-fdc6-43ba-ac701cfde80c@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).